OtherDevices items flickers when changing device to landscape |
|||||||
Issue descriptionApp Version: 70.0.3536.0 canary iOS Version: 11.4.1 Devices: iPhone X Only Precondition: Have Recently Closed items Steps to reproduce: 1. Launch Google Chrome 2. Change device mode to landscape 3. Tap on Tab switcher 4. Tap on Other Devices icon 5. Change device to portrait Observed results: OtherDevices items flickers when changing device to landscape Expected results: OtherDevices items should not flicker when changing device to landscape Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on the current stable build :M68, Yes Bug reproducible on the current beta channel build :M69, Yes Link to Image/Video: https://drive.google.com/file/d/1cpwpi6kjSVvGyKo7DswzxBNGcX3G4qfY/view
,
Aug 31
yeah it must be because I'm editing the additionalSafeAreaInsets after the rotation animation transition finishes.
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249 commit ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249 Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue Sep 04 15:28:24 2018 [ios] Move RemoteTabs additionalSafeAreaInset modification in Tabgrid to during rotation animation Currently making modifications in the completion block results in flickers during rotations. Video: https://drive.google.com/open?id=1rtjOugnQaVRqO9mtflrEIgUJ16oipic2 Bug: 878832 Change-Id: Icee69d81199ff068c3ac74a768d0ee4509372826 Reviewed-on: https://chromium-review.googlesource.com/1199931 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#588521} [modify] https://crrev.com/ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249 commit ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249 Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue Sep 04 15:28:24 2018 [ios] Move RemoteTabs additionalSafeAreaInset modification in Tabgrid to during rotation animation Currently making modifications in the completion block results in flickers during rotations. Video: https://drive.google.com/open?id=1rtjOugnQaVRqO9mtflrEIgUJ16oipic2 Bug: 878832 Change-Id: Icee69d81199ff068c3ac74a768d0ee4509372826 Reviewed-on: https://chromium-review.googlesource.com/1199931 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#588521} [modify] https://crrev.com/ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249 commit ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249 Author: Chris Lu <thegreenfrog@chromium.org> Date: Tue Sep 04 15:28:24 2018 [ios] Move RemoteTabs additionalSafeAreaInset modification in Tabgrid to during rotation animation Currently making modifications in the completion block results in flickers during rotations. Video: https://drive.google.com/open?id=1rtjOugnQaVRqO9mtflrEIgUJ16oipic2 Bug: 878832 Change-Id: Icee69d81199ff068c3ac74a768d0ee4509372826 Reviewed-on: https://chromium-review.googlesource.com/1199931 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#588521} [modify] https://crrev.com/ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Sep 5
kariahda@ I'd like to cherry pick this to into M-70
,
Sep 6
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b43ee6e5db2fa56deefbcc76a505d8f43df061f commit 0b43ee6e5db2fa56deefbcc76a505d8f43df061f Author: Chris Lu <thegreenfrog@chromium.org> Date: Thu Sep 06 23:28:57 2018 [ios] Move RemoteTabs additionalSafeAreaInset modification in Tabgrid to during rotation animation Currently making modifications in the completion block results in flickers during rotations. Video: https://drive.google.com/open?id=1rtjOugnQaVRqO9mtflrEIgUJ16oipic2 Bug: 878832 Change-Id: Icee69d81199ff068c3ac74a768d0ee4509372826 Reviewed-on: https://chromium-review.googlesource.com/1199931 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588521}(cherry picked from commit ffbaa8b35745ca3c87c0a69f3cac9ed9850f7249) Reviewed-on: https://chromium-review.googlesource.com/1211871 Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#114} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/0b43ee6e5db2fa56deefbcc76a505d8f43df061f/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
,
Sep 7
,
Sep 11
Verified the issue on the build version 71.0.3549.0 canary tested on iPhone X iOS 11.4.1. Flickering is not seen on changing the other devices, looks good.
,
Sep 12
Verified in 70.0.3538.13 Beta in iPhone X(iOS 11.4.1) Flickering is not seen on changing other devices orientation, looks good Link to video: https://drive.google.com/file/d/1hPkwIj8CebRyhHisHhMwhS3hSRBl9YUy/view?usp=sharing |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sczs@chromium.org
, Aug 29Labels: -Pri-2 M-70 Pri-1
Owner: thegreenfrog@chromium.org
Status: Assigned (was: Untriaged)