New issue
Advanced search Search tips

Issue 878807 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Improve official build coverage on clang ToT waterfall

Project Member Reported by r...@chromium.org, Aug 29

Issue description

The last clang roll attempt had to be reverted here:
https://bugs.chromium.org/p/chromium/issues/detail?id=871418#c23
Because the official Linux bot went red here:
https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Linux%20x64/35385

We don't currently seem to have Linux official build coverage on the tot waterfall.

We could repurpose our existing LTO builder to be the official builder, since right now official builds on Linux use ThinLTO. I think Linux official builds also happen to use CFI today, so we might lose the ability to see if ThinLTO without CFI works. Should we do that, or should we add a new official bot to the waterfall? We could call it "off" or "ofc" in the LUCI UI to match our three letter names.

If we're adding VMs, then I'd also like to have separate bots for the Windows release configuration and the official configuration. The regular release build configuration is probably the most stable build configuration, while the tests never pass in the official build configuration. I'd like to be able to see "green rel, red official, test failures only, OK not our bug, roll clang".

Lastly, maybe this should all happen after the LUCI bot mirroring, which I heard was scheduled for next week.
 
Before ThinLTO, I would have argued for just making the Release ToT bots do official builds, but since the official and non-official configs are now so different, I think it makes sense to get more VMs and cover both. I think Linux VMs are reasonably cheap too.
Cc: p...@chromium.org
I'd just make the ThinLTO bot do official bots. Since we don't ship or use thinlto without cfi, I'm not sure if we need coverage of that.
(on linux, that is)

Sign in to add a comment