AppListView::CloseOpenedPage crash on signing in |
||
Issue descriptionThis crash happened on bob-paladin bot. https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8936870224745083424 Looks like app list is not created and we hit a SEGFAULT in AppListControllerImpl::OnActiveUserPrefServiceChanged [1] where presenter is holding a null view. [1]: https://cs.chromium.org/chromium/src/ash/app_list/app_list_controller_impl.cc?rcl=808ee09c1dffa440178ad98a0cd99b27165233ad&l=414 Stack ==== Operating system: Linux 0.0.0 Linux 4.4.151-15089-g4351aed3bd2d #1 SMP PREEMPT Wed Aug 29 03:29:17 PDT 2018 aarch64 CPU: arm ARMv1 ARM part(0x4100d0b0) features: half,thumb,fastmult,vfpv2,edsp,neon,vfpv3,tls,vfpv4,idiva,idivt 6 CPUs GPU: UNKNOWN Crash reason: SIGSEGV Crash address: 0x0 Process uptime: not available Thread 0 (crashed) 0 chrome!app_list::AppListView::CloseOpenedPage() [app_list_view.cc : 399 + 0x0] r0 = 0x00000000 r1 = 0x00000000 r2 = 0x06143e35 r3 = 0x08c51d58 r4 = 0x00000000 r5 = 0xf7581ec0 r6 = 0x09551adc r7 = 0xffc07d50 r8 = 0x00029dcc r9 = 0x00000000 r10 = 0x09551adc r12 = 0x048825c9 fp = 0x08c51d58 sp = 0xffc07d48 lr = 0x06143e71 pc = 0x0636347a Found by: given as instruction pointer in context 1 chrome!non-virtual thunk to ash::AppListControllerImpl::OnActiveUserPrefServiceChanged(PrefService*) [app_list_controller_impl.cc : 407 + 0x3] r4 = 0x09db1e00 r5 = 0xf7581ec0 r6 = 0x09551adc r7 = 0xffc07d60 r8 = 0x00029dcc r9 = 0x00000000 r10 = 0x09551adc fp = 0x08c51d58 sp = 0xffc07d58 pc = 0x06143e71 Found by: call frame info 2 chrome!ash::SessionController::MaybeNotifyOnActiveUserPrefServiceChanged() [session_controller.cc : 697 + 0x1] r4 = 0x09c670e0 r5 = 0xf7581ec0 r6 = 0x09551adc r7 = 0xffc07da8 r8 = 0x00029dcc r9 = 0x00000000 r10 = 0x09551adc fp = 0x08c51d58 sp = 0xffc07d68 pc = 0x06182981 Found by: call frame info Full stack walk attached.
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09012adaefe038554a924e46564d712fba15ddad commit 09012adaefe038554a924e46564d712fba15ddad Author: Weidong Guo <weidongg@chromium.org> Date: Wed Aug 29 20:38:30 2018 Fix crash for AppListControllerImpl::OnActiveUserPrefServiceChanged Changes: Since OnActiveUserPrefServiceChanged must be called after OnSessionStateChanged, so we only need to keep the former one. This also fixed the crash caused by app list view being null. Bug: 878803 Change-Id: I3744e21bbdb30a1065027999c81b2477d391667b Reviewed-on: https://chromium-review.googlesource.com/1195742 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#587284} [modify] https://crrev.com/09012adaefe038554a924e46564d712fba15ddad/ash/app_list/app_list_controller_impl.cc [modify] https://crrev.com/09012adaefe038554a924e46564d712fba15ddad/ash/app_list/app_list_controller_impl.h
,
Aug 29
,
Sep 7
Issue 879408 has been merged into this issue. |
||
►
Sign in to add a comment |
||
Comment 1 by weidongg@chromium.org
, Aug 29