New issue
Advanced search Search tips

Issue 878796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Clean up Reading List Mediator as part of UIRefresh cleanup

Project Member Reported by thegreenfrog@chromium.org, Aug 29

Issue description

- Remove deprecated init method
- Remove LarceIconService and attributesProperty property
 
Labels: OS-iOS
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7fbec49a2bb44a1fbcef5e6c826ef7892b71ebe

commit c7fbec49a2bb44a1fbcef5e6c826ef7892b71ebe
Author: Chris Lu <thegreenfrog@chromium.org>
Date: Mon Oct 01 15:38:51 2018

[ios] Remove AtrributesProvider logic from ReadingListMediator

AtrributesProvider was used in legacy reading list logic. FaviconLoader is now the preferred method.

Bug:  878796 
Change-Id: I009c762dfe7053e149c6b94b2145c4f68008a304
Reviewed-on: https://chromium-review.googlesource.com/1252523
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595458}
[modify] https://crrev.com/c7fbec49a2bb44a1fbcef5e6c826ef7892b71ebe/ios/chrome/browser/ui/reading_list/reading_list_mediator.h
[modify] https://crrev.com/c7fbec49a2bb44a1fbcef5e6c826ef7892b71ebe/ios/chrome/browser/ui/reading_list/reading_list_mediator.mm
[modify] https://crrev.com/c7fbec49a2bb44a1fbcef5e6c826ef7892b71ebe/ios/chrome/browser/ui/reading_list/reading_list_mediator_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment