New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878794 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add finch switch to control chrome cleanup tool quarantine feature.

Project Member Reported by cheyuw@google.com, Aug 29

Issue description

The new quarantine feature is going to land in the chrome cleanup tool.
So we need a finch switch to enable/disable it so as to do experiments on the quarantine feature and see how it performs.
 
Description: Show this description
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 29

Labels: Hotlist-Recharge-BouncingOwner
Owner: ----
The assigned owner "cheyuw@google.com" is not able to receive e-mails, please re-triage.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: cheyuw@google.com
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d99f84674492c1cb5859f46e7f39a0250f8a0295

commit d99f84674492c1cb5859f46e7f39a0250f8a0295
Author: Che-yu Wu <cheyuw@google.com>
Date: Thu Aug 30 19:35:21 2018

Chrome Cleaner: add finch switch for quarantine feature

The new quarantine feature for chrome cleanup tool needs a finch switch to control it.
It adds "--quarantine" into the command line when launching the cleaner if the switch is enabled.
It will be only enabled on the cleaner. So only adds switch to the cleaner, but not to the reporter.
Default is disabled.

Bug:  crbug.com/878794 
Change-Id: Ibb6f7bf76c36fbaf6106ede1ee9b6049cb2c5d2e
Reviewed-on: https://chromium-review.googlesource.com/1194404
Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: Che-yu Wu <cheyuw@google.com>
Cr-Commit-Position: refs/heads/master@{#587710}
[modify] https://crrev.com/d99f84674492c1cb5859f46e7f39a0250f8a0295/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win.cc
[modify] https://crrev.com/d99f84674492c1cb5859f46e7f39a0250f8a0295/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_runner_win_unittest.cc
[modify] https://crrev.com/d99f84674492c1cb5859f46e7f39a0250f8a0295/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
[modify] https://crrev.com/d99f84674492c1cb5859f46e7f39a0250f8a0295/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h
[modify] https://crrev.com/d99f84674492c1cb5859f46e7f39a0250f8a0295/components/chrome_cleaner/public/constants/constants.cc
[modify] https://crrev.com/d99f84674492c1cb5859f46e7f39a0250f8a0295/components/chrome_cleaner/public/constants/constants.h

Status: Fixed (was: Untriaged)

Sign in to add a comment