New issue
Advanced search Search tips

Issue 878779 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 12
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 0
Type: Bug



Sign in to add a comment

Chrome Headless doesn't start on windows

Project Member Reported by lushnikov@chromium.org, Aug 29

Issue description

Step-by-step:
1. compile chrome on windows
2. try to run chrome with "--headless --disable-breakpad" flags

Expected: doesn't crash.

Actual: crashes with CHECK.

[0829/142336.639:FATAL:feature_list.cc(240)] Check failed: !g_initialized_from_accessor.
Backtrace:
        base::debug::StackTrace::StackTrace [0x00007FFB89EC1895+101] (d:\alexclarke\src\base\debug\stack_trace_win.cc:286)
        base::debug::StackTrace::StackTrace [0x00007FFB89EC08CF+31] (d:\alexclarke\src\base\debug\stack_trace.cc:199)
        logging::LogMessage::~LogMessage [0x00007FFB89F291B6+134] (d:\alexclarke\src\base\logging.cc:600)
        base::FeatureList::InitializeInstance [0x00007FFB89EDA243+163] (d:\alexclarke\src\base\feature_list.cc:241)
        content::BrowserMainLoop::EarlyInitialization [0x00007FFB6116353F+751] (d:\alexclarke\src\content\browser\browser_main_loop.cc:626)
        content::BrowserMainRunnerImpl::Initialize [0x00007FFB61178BD4+1316] (d:\alexclarke\src\content\browser\browser_main_runner_impl.cc:119)
        headless::HeadlessContentMainDelegate::RunProcess [0x00007FFB4BAA2DB1+257] (d:\alexclarke\src\headless\lib\headless_content_main_delegate.cc:278)
        content::RunBrowserProcessMain [0x00007FFB63DDB650+112] (d:\alexclarke\src\content\app\content_main_runner_impl.cc:528)
        content::ContentMainRunnerImpl::Run [0x00007FFB63DDC9EC+988] (d:\alexclarke\src\content\app\content_main_runner_impl.cc:903)
        content::ContentServiceManagerMainDelegate::RunEmbedderProcess [0x00007FFB63DD8D47+55] (d:\alexclarke\src\content\app\content_service_manager_main_delegate.cc:53)
        service_manager::Main [0x00007FFB7B655122+1762] (d:\alexclarke\src\services\service_manager\embedder\main.cc:472)
        content::ContentMain [0x00007FFB63DDB54F+95] (d:\alexclarke\src\content\app\content_main.cc:20)
        headless::`anonymous namespace'::RunContentMain [0x00007FFB4B4BDCE0+640] (d:\alexclarke\src\headless\lib\browser\headless_browser_impl.cc:69)
        headless::HeadlessBrowserMain [0x00007FFB4B4BDFB4+564] (d:\alexclarke\src\headless\lib\browser\headless_browser_impl.cc:287)
        headless::HeadlessShellMain [0x00007FFB6961CC25+4581] (d:\alexclarke\src\headless\app\headless_shell.cc:772)
        headless::HeadlessShellMain [0x00007FFB6961D180+32] (d:\alexclarke\src\headless\app\headless_shell.cc:779)
        ChromeMain [0x00007FFB66FE12C4+404] (d:\alexclarke\src\chrome\app\chrome_main.cc:97)
        MainDllLoader::Launch [0x00007FF6A5CDC074+1124] (d:\alexclarke\src\chrome\app\main_dll_loader_win.cc:201)
        wWinMain [0x00007FF6A5CD1470+1136] (d:\alexclarke\src\chrome\app\chrome_exe_main_win.cc:230)
        invoke_main [0x00007FF6A5F998BD+45] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:123)
        __scrt_common_main_seh [0x00007FF6A5F999F4+292] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
        __scrt_common_main [0x00007FF6A5F99A7E+14] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326)
        wWinMainCRTStartup [0x00007FF6A5F99A99+9] (f:\dd\vctools\crt\vcstartup\src\startup\exe_wwinmain.cpp:17)
        BaseThreadInitThunk [0x00007FFBB2ED3034+20]
        RtlUserThreadStart [0x00007FFBB39F1431+33]

Bisect: https://chromium.googlesource.com/chromium/src/+log/4b287a61d952026a84421b51f61859ccfa263929..f94b4106732d4abfd4cc1db54e87aec519b02ae4

Offending patch: https://chromium-review.googlesource.com/c/chromium/src/+/1171482


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70a9d8a7f95c4d9fc189fd8c2eb78e5702cb7c1c

commit 70a9d8a7f95c4d9fc189fd8c2eb78e5702cb7c1c
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Wed Aug 29 16:47:14 2018

Revert "[Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland)."

This patch reverts:
- https://crrev.com/586836 - [Base] Support ::GetThreadPriority() returning THREAD_PRIORITY_IDLE.
- https://crrev.com/586311 - [Base] Use background mode for ThreadPriority::BACKGROUND threads (behind feature) (reland).

The https://crrev.com/586836 is reverted since it is atop of the https://crrev.com/586311.

TBR=gab@chromium.org

R=fdoray, gab

Bug:  878779 
Change-Id: If13da0992065eed1b5cc4f39c26e5339454d9230
Reviewed-on: https://chromium-review.googlesource.com/1194035
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587156}
[modify] https://crrev.com/70a9d8a7f95c4d9fc189fd8c2eb78e5702cb7c1c/base/BUILD.gn
[modify] https://crrev.com/70a9d8a7f95c4d9fc189fd8c2eb78e5702cb7c1c/base/threading/platform_thread_unittest.cc
[modify] https://crrev.com/70a9d8a7f95c4d9fc189fd8c2eb78e5702cb7c1c/base/threading/platform_thread_win.cc
[delete] https://crrev.com/c749e5a5eaf0cf03dba8954f0bf19fe80b02745c/base/threading/platform_thread_win.h

Project Member

Comment 2 by sheriffbot@chromium.org, Sep 12

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Assigned)

Sign in to add a comment