New issue
Advanced search Search tips

Issue 878773 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Sep 6
Cc:
dtapu...@chromium.org
foolip@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove initial_page_scale_factor_, initial_scroll_offset, and initial_visual_viewport_offset

Project Member Reported by dtapu...@chromium.org, Aug 29 
Remove the fields as they aren't necessary.

Upon exiting fullscreen set the page scale factor to the default. 

This is logically more sensible because you if you have a document element and it enters fullscreen then when you exit fullscreen it should maintain its scroll position you had in fullscreen not jump around.

Since the restoration of the viewport offset and page scale factor go back to the value they were before fullscreen. When we exit fullscreen we should just reset them to the default.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41e9b7cc9cadb4996079120292cf1aa6ca4722ec

commit 41e9b7cc9cadb4996079120292cf1aa6ca4722ec
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Thu Sep 06 16:42:35 2018

Remove initial scroll, scale and offset restoration.

Upon exiting fullscreen restore back to the default page scale instead
of restoring old values. This is a simplier model and doesn't cause
scroll jumping when the page scale isn't changing.

BUG= 878773 

Change-Id: I107e517bd3c76300d0a8ce02622f4a05dc9ce79b
Reviewed-on: https://chromium-review.googlesource.com/1195714
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589190}
[modify] https://crrev.com/41e9b7cc9cadb4996079120292cf1aa6ca4722ec/third_party/blink/renderer/core/exported/web_frame_test.cc
[modify] https://crrev.com/41e9b7cc9cadb4996079120292cf1aa6ca4722ec/third_party/blink/renderer/core/exported/web_view_impl.cc
[modify] https://crrev.com/41e9b7cc9cadb4996079120292cf1aa6ca4722ec/third_party/blink/renderer/core/exported/web_view_test.cc
[modify] https://crrev.com/41e9b7cc9cadb4996079120292cf1aa6ca4722ec/third_party/blink/renderer/core/frame/fullscreen_controller.cc
[modify] https://crrev.com/41e9b7cc9cadb4996079120292cf1aa6ca4722ec/third_party/blink/renderer/core/frame/fullscreen_controller.h

Comment 2 by dtapu...@chromium.org, Sep 6

Status: Fixed (was: Available)
►

Sign in to add a comment