Unified: Notification corner not rounded in settings mode |
||||||||||
Issue descriptionChrome Version: 70.0.3536.0 Steps To Reproduce: (1) open tests.peter.sh/notification-generator/ and display a notification (2) open uber tray (3) click the gear icon (settings) on the notification in the unified message center (4) scroll up and down to see the shape of the notification. Expected Result: The setting view of the notification is kept inside the border Both the top and the bottom corners should be rounded because there's only 1 notification. Actual Result: The settings view gets out of the rounded corners What is the impact to the user, and is there a workaround? If so, what is it? This is a cosmetic issue. This did not happen before introduction of unified system tray.
,
Aug 29
This issue was confirmed on commit 876c66325c. This is not related to the modification of the notification container view (crbug.com/840497, crrev.com/c/1184724, reverted at 55a7602) because it's not effective in this revision.
,
Aug 29
,
Aug 30
,
Aug 30
Issue 863252 has been merged into this issue.
,
Aug 30
,
Sep 21
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/446e74224f0d0a799a4db71588650808945873d0 commit 446e74224f0d0a799a4db71588650808945873d0 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Oct 11 01:08:07 2018 Unified: Round corners of inline settings. In UnifiedSystemTray, a notification can have different radii for the top and the bottom corners. This CL applies custom mask to ink drop of NotificationViewMD so that these corners are properly painted even in inline settings. TEST=manual BUG=878772 Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584 Reviewed-on: https://chromium-review.googlesource.com/c/1195258 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#598609} [modify] https://crrev.com/446e74224f0d0a799a4db71588650808945873d0/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/446e74224f0d0a799a4db71588650808945873d0/ui/message_center/views/notification_view_md.h
,
Oct 11
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b commit 35cfc1aed4eb74a8351902ae3a24cb630cb1b83b Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Thu Oct 25 08:03:17 2018 Revert "Unified: Round corners of inline settings." This reverts commit 446e74224f0d0a799a4db71588650808945873d0. Reason for revert: regression for popups https://crbug.com/898094 Original change's description: > Unified: Round corners of inline settings. > > In UnifiedSystemTray, a notification can have different radii for the > top and the bottom corners. This CL applies custom mask to ink drop of > NotificationViewMD so that these corners are properly painted even in > inline settings. > > TEST=manual > BUG=878772 > > Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584 > Reviewed-on: https://chromium-review.googlesource.com/c/1195258 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598609} TBR=yoshiki@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 878772, 898094 Change-Id: I65c0281cf1ff3448d61344bb2b447bbe3ec05ef5 Reviewed-on: https://chromium-review.googlesource.com/c/1298529 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#602642} [modify] https://crrev.com/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/35cfc1aed4eb74a8351902ae3a24cb630cb1b83b/ui/message_center/views/notification_view_md.h
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba Commit: c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba Author: tetsui@chromium.org Commiter: tetsui@chromium.org Date: 2018-10-26 02:17:28 +0000 UTC Revert "Unified: Round corners of inline settings." This reverts commit 446e74224f0d0a799a4db71588650808945873d0. Reason for revert: regression for popups https://crbug.com/898094 Original change's description: > Unified: Round corners of inline settings. > > In UnifiedSystemTray, a notification can have different radii for the > top and the bottom corners. This CL applies custom mask to ink drop of > NotificationViewMD so that these corners are properly painted even in > inline settings. > > TEST=manual > BUG=878772 > > Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584 > Reviewed-on: https://chromium-review.googlesource.com/c/1195258 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598609} TBR=yoshiki@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 878772, 898094 Change-Id: I65c0281cf1ff3448d61344bb2b447bbe3ec05ef5 Reviewed-on: https://chromium-review.googlesource.com/c/1298529 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602642}(cherry picked from commit 35cfc1aed4eb74a8351902ae3a24cb630cb1b83b) Reviewed-on: https://chromium-review.googlesource.com/c/1300816 Cr-Commit-Position: refs/branch-heads/3578@{#341} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba commit c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Fri Oct 26 02:17:28 2018 Revert "Unified: Round corners of inline settings." This reverts commit 446e74224f0d0a799a4db71588650808945873d0. Reason for revert: regression for popups https://crbug.com/898094 Original change's description: > Unified: Round corners of inline settings. > > In UnifiedSystemTray, a notification can have different radii for the > top and the bottom corners. This CL applies custom mask to ink drop of > NotificationViewMD so that these corners are properly painted even in > inline settings. > > TEST=manual > BUG=878772 > > Change-Id: Ib8bf5f8e34c3f30c1e8ac3b32ee6d4a1ff6a6584 > Reviewed-on: https://chromium-review.googlesource.com/c/1195258 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#598609} TBR=yoshiki@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 878772, 898094 Change-Id: I65c0281cf1ff3448d61344bb2b447bbe3ec05ef5 Reviewed-on: https://chromium-review.googlesource.com/c/1298529 Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#602642}(cherry picked from commit 35cfc1aed4eb74a8351902ae3a24cb630cb1b83b) Reviewed-on: https://chromium-review.googlesource.com/c/1300816 Cr-Commit-Position: refs/branch-heads/3578@{#341} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/c32ed7b7d91dc4adf11417cf01cec6aadaaf57ba/ui/message_center/views/notification_view_md.h
,
Oct 26
,
Dec 12
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by yamaguchi@chromium.org
, Aug 29