Regression: [NTP] Unwanted focus ring is seen on disabled 'Restore default background' text while selecting all text.
Reported by
db...@etouch.net,
Aug 29
|
|||||||
Issue descriptionChrome Version:70.0.3535.4 Revision 94e3d408570fcf39b8718d8d1637e978e11803bc-refs/branch-heads/3535@{#6}(32/64 bit) OS: Mac (10.12.6, 10.13.1,10.13.6, 10.14),Windows(7,8,8.1,10) & Linux(14.04 LTS) Precondition: Enabled 'Enable using the Google local NTP' and 'New Tab Page Background Selection' flags from chrome://flags page. What steps will reproduce the problem? (1) Launch chrome, open NTP and click on Gear icon. (2) Press Tab click and then try to select all text on 'Customise this page' overlay. (3) Observe focus ring on 'Restore default background' text Actual: Unwanted focus ring is seen on disabled 'Restore default background' text while selecting all text. Expected: Focus ring should not seen on disabled 'Restore default background' text. This is a regression, broken in 'M70', below is bisect info: Good Build:70.0.3508.0(Revision:579242) Bad Build: 70.0.3509.0(Revision:579853) You are probably looking for a change made after 579298 (known good), but no later than 579299 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/fdd14161e14fe8d2f0578ebddd4578a4e1f674cb..7a26d4f6d9ab30f8550e8af4bb9ef65ca5740a6f Suspect: https://chromium.googlesource.com/chromium/src/+/7a26d4f6d9ab30f8550e8af4bb9ef65ca5740a6f kristipark@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank you.
,
Aug 29
,
Aug 30
,
Aug 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6d416bbb12f1944cb27350b394781d2acd7c3ff commit b6d416bbb12f1944cb27350b394781d2acd7c3ff Author: Weilun Shi <sweilun@chromium.org> Date: Thu Aug 30 22:00:45 2018 [NTP] Remove focus ring on disabled option Removing focus ring when focusing on diabled options on "customize this page" dialog. Bug: 878769 Change-Id: I71466a87f4f1ea76022a09c072894d5ee9af1ed0 Reviewed-on: https://chromium-review.googlesource.com/1195932 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#587802} [modify] https://crrev.com/b6d416bbb12f1944cb27350b394781d2acd7c3ff/chrome/browser/resources/local_ntp/custom_backgrounds.css [modify] https://crrev.com/b6d416bbb12f1944cb27350b394781d2acd7c3ff/chrome/browser/resources/local_ntp/custom_backgrounds.js
,
Aug 31
,
Aug 31
Update: Retested above issue on Latest canary build #70.0.3538.0 using Mac (10.12.6, 10.13.1,10.13.6, 10.14),Windows(7,8,8.1,10) & Linux(14.04 LTS) and issue is fixed and working as intended. Thank you.
,
Sep 10
,
Oct 9
Not reproducible in remote. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by kristip...@chromium.org
, Aug 29