New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878752 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Able to perform 'Undo' / 'Restore default shortcuts' actions even when buttons are not visible on NTP

Reported by vineetha...@etouch.net, Aug 29

Issue description

Chrome version : 70.0.3535.4 (Official Build) 94e3d408570fcf39b8718d8d1637e978e11803bc-refs/branch-heads/3535@{#6}(32/64-bit) 
OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)  OS

Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" and "New Tab Page Custom Links" flags under chrome://flags.

Steps to reproduce:
1. Launch chrome and open NTP.
2. Click on 'Add Shortcut' icon and add anew shortcut to NTP.
3. Observe that a confirmation message of 'Shortcut added' along with 'Undo' and 'Restore default shortcuts' buttons is seen.
4. Wait for the confirmation message to go away.
5. Press tab till focus reaches 'Add shortcut' icon now press tab again , press enter and observe

Actual Result  :Able to navigate to 'Undo' or 'Restore default shortcuts' buttons even when confirmation message is not seen.
Expected Result:Should not be able to navigate to 'Undo' or 'Restore default shortcuts' when confirmation message is not seen ,instead focus should travel directly from 'Add shortcut' icon to gear icon.

This is a regression issue broken in ‘M-70’ and below is bisect info.
Good build: 70.0.3532.0(585633)
Bad build : 70.0.3533.0(586155)

Tried per revision bisect on Windows ,Mac and Linux OS but unable to perform the same since getting error, hence providing narrow bisect, 

Narrow bisect:

https://chromium.googlesource.com/chromium/src/+log/7f33da45163ef62e91db336f0891d049366e309a..8309e7af7a65c9ce3ccad51d16a36e4cd25cb8d9?pretty=fuller&n=50

Suspect: https://chromium.googlesource.com/chromium/src/+/551d7d730370d3f017eca38d9d9b2d42f9812ec8

@kristipark: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You

 
ActualVideo.mp4
601 KB View Download
ExpectedVideo.mp4
688 KB View Download
This is a known issue and will be fixed once the next Canary is released.
Status: Fixed (was: Assigned)
To clarify, this was fixed in http://crbug/874188
Cc: -ramyan@google.com ramyan@chromium.org

Sign in to add a comment