Ensure we test the right WebView APKs on perf bots |
||||||
Issue descriptionTurns out the new webview perf bots (android-go_webview-perf and android-pixel2_webview-perf) are *not* testing the right APK. They both currently install: - MonochromePublic.apk - SystemWebViewShell.apk But do *not* set MonochromePublic.apk as webview provider [1]. So I assume these are just testing the default system webview on the device? Moreover, from the discussions in [2], setting MonochromePublic.apk as webview provider should not be possible at all. The bots are respectively equipped with the following devices: - gobo - OMB1.180119.001 - Pixel 2 (walleye) - OPM1.171019.021 Note these are *not* AOSP builds. APKs included in the inputs for these bots include: - out/Release/apks/ChromePublic.apk - out/Release/apks/MonochromePublic.apk - out/Release/apks/SystemWebView.apk - out/Release/apks/SystemWebViewShell.apk So, which APKs should we be installing on the devices? And which entry point should we be using to test WebView? [1]: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py?rcl=6443c8dade1c92969e05e8232dc013971433da1d&l=297 [2]: https://docs.google.com/a/google.com/document/d/1pzuYe7sZntKxas6sk-OJGFoQ4d_u2g3Xcaj7D3_uDec/edit?disco=AAAACEsMrB4
,
Aug 29
Ok, so I see we basically have two choices: a) Wait and block on DEPS inversion, after which we'll be able to have Monochrome.apk available for these bots. b) Get AOSP builds for these devices. Then, after DEPS inversion, switch devices back to non-AOSP. +jbudorick, how far do you think we are from DEPS inversion happening?
,
Aug 30
,
Aug 30
torne, if we get AOSP builds on the devices, then we would need to install these? - out/Release/apks/SystemWebView.apk - out/Release/apks/SystemWebViewShell.apk Do we also need to select SystemWebView.apk (which package name?) as webview provider?
,
Aug 30
AOSP builds only have this package as webview provider so there's no need to select anything. However, the AOSP build will have this APK signed with a different key than the one the bot uses, so we'll still have to root the device and remove the existing webview from the system image to be able to install this one.
,
Aug 30
Re #5: Sounds good, that's what existing WebView bots (Nexus 5X and 6) do.
+vhang, would it be possible to flash all devices currently attached to:
bot_id: "build{228..232}-a7" # android-go_webview-perf
https://chrome-internal.googlesource.com/infradata/config/+/273f10ff062adbeef8bba9a88bbc5bc406da2333/configs/chrome-swarming/bots.cfg#667
and
bot_id: "build29-a7" # Pixel2 Webview
https://chrome-internal.googlesource.com/infradata/config/+/273f10ff062adbeef8bba9a88bbc5bc406da2333/configs/chrome-swarming/bots.cfg#713
To matching AOSP Oreo builds?
,
Sep 11
Ping, Vince. Or should I add this to some bug queue?
,
Sep 11
,
Nov 23
This problem is now being side-stepped by installing Monochrome.apk on these bots for issue 817842. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by torne@chromium.org
, Aug 29