Regression: [NTP] 'Enter' key input cause 'Add shortcut' overlay disappear
Reported by
khushal....@etouch.net,
Aug 29
|
||||||
Issue descriptionChrome Version: 70.0.3535.4 (Official Build) Revision 94e3d408570fcf39b8718d8d1637e978e11803bc-refs/branch-heads/3535@{#6} (32/64-bit) OS: Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) Pre-condition: Enable the flags "Enable using the Google local NTP" and "New Tab Page Custom Links" from chrome://flags/ What steps will reproduce the problem? (1) Launch chrome and open NTP. (2) Now click on 'Add shortcut' thumbnail and press 'Enter' key from keyboard. (3) Observe. Actual Result: 'Enter' key input cause 'Add shortcut' overlay disappear. Expected Result: 'Enter' key input should not close 'Add shortcut' overlay. This is a Regression issue seen from 'M-70' and providing the bisect info below: Good Build: 70.0.3514.0 (Revision: 580791) Bad Build: 70.0.3515.0 (Revision: 581084) You are probably looking for a change made after 580948 (known good), but no later than 580949 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/631ac11aae294abc8b5a100a09e59af59aa6e229..c2111e0695751dcd6833f86930ea7905daef9494 Suspect: https://chromium.googlesource.com/chromium/src/+/c2111e0695751dcd6833f86930ea7905daef9494 @kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: Issue is also seen on M-70 Dev (build #70.0.3534.4). Kindly refer the attached screen-cast. Thank You..!!
,
Sep 10
+Yana FYI Specifically, the Add Shortcut dialog closes if Enter is pressed when either of the input fields is in focus.
,
Sep 12
cc'ing Laura as having the "Add shortcut" close on another "enter" was something, IIRC, that was specifically requested in an accessibility review.
,
Sep 13
Hey - I'm sorry if there was some confusion here... pressing Enter alone shouldn't just close this UI. The keyboard focus would need to be on the cancel button in order for pressing Enter to close it. Pressing Esc should close this UI, or the user should be able to tab navigate to the cancel or done button to then press Enter and close it.
,
Sep 13
Re-opening given Laura's clarification in c4. From a usability perspective, I think it can be strange to close-on-enter if none of the buttons have keyboard focus.
,
Sep 13
And one last note: if a user has entered information, enter should continue to act as it does now: Save it and then close the UI (As is currently the case).
,
Sep 13
@c6: 👍🏼👍🏼👍🏼
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24acbdb062ccf13a8b215bec89d3b91cd5d6e787 commit 24acbdb062ccf13a8b215bec89d3b91cd5d6e787 Author: kristipark <kristipark@chromium.org> Date: Fri Sep 14 01:58:56 2018 [NTP] Prevent the add custom link dialog from closing on enter if the Done button is disabled Enter should only close the dialog if the text field has been modified. Bug: 878740 Change-Id: I103ca78f501b33957dd2895a0a67b2a2942fe4ff Reviewed-on: https://chromium-review.googlesource.com/1226272 Reviewed-by: Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#591260} [modify] https://crrev.com/24acbdb062ccf13a8b215bec89d3b91cd5d6e787/chrome/browser/resources/local_ntp/custom_links_edit.js
,
Sep 14
,
Sep 17
Update: Rechecked the above issue on Mac (10.12.6, 10.13.1, 10.13.6, 10.14), Win (7, 8, 8.1, 10) & Linux (14.04 LTS) OS using latest canary version #71.0.3554.0 and the issue is found FIXED. Hence, adding respective labels. Please refer the attached screen-cast. Thank You..!! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kristip...@chromium.org
, Aug 29