New issue
Advanced search Search tips

Issue 878736 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Sep 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

New policy values to control rollback save and restore data behavior

Project Member Reported by hunyadym@chromium.org, Aug 29

Issue description

RollbackAndRestoreIfPossible: always roll back, but try to save and restore data if possible.

RollbackWithRestoreOnly: only roll back if it's possible to save and restore data.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9f2b8fa7cf29f62ecfd5e9371cdcd75085d68ce

commit d9f2b8fa7cf29f62ecfd5e9371cdcd75085d68ce
Author: Marton Hunyady <hunyadym@chromium.org>
Date: Thu Aug 30 16:05:29 2018

Add new policy values for DeviceRollbackToTargetVersion policy

The new values are:
- RollbackAndRestoreIfPossible: always roll back, but try to save and
  restore data if possible.
- RollbackWithRestoreOnly: only roll back if it's possible to save and
  restore data.

Bug:  878736 
Change-Id: I0455ee4c38537430cb27a86befe51d09d6e312ef
Reviewed-on: https://chromium-review.googlesource.com/1194124
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587605}
[modify] https://crrev.com/d9f2b8fa7cf29f62ecfd5e9371cdcd75085d68ce/components/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/d9f2b8fa7cf29f62ecfd5e9371cdcd75085d68ce/components/policy/resources/policy_templates.json

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/31aefb9f77cb237594e7af599b32ec93df9f20fd

commit 31aefb9f77cb237594e7af599b32ec93df9f20fd
Author: Marton Hunyady <hunyadym@chromium.org>
Date: Fri Aug 31 07:27:58 2018

update_engine: Add new rollback policy values

The new values are:
- RollbackAndRestoreIfPossible: always roll back, but try to save and
  restore data if possible. This is rollback_allowed=true.
- RollbackWithRestoreOnly: only roll back if it's possible to save and
  restore data. This is rollback_allowed=false until data save and
  restore is implemented.

BUG= chromium:878736 
TEST='cros_run_unit_tests --board=caroline --packages update_engine'

Change-Id: Ifd198610c26d11521b39da8fce5f44dc97609bf5
Reviewed-on: https://chromium-review.googlesource.com/1194229
Commit-Ready: Marton Hunyady <hunyadym@chromium.org>
Tested-by: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/31aefb9f77cb237594e7af599b32ec93df9f20fd/update_manager/rollback_prefs.h
[modify] https://crrev.com/31aefb9f77cb237594e7af599b32ec93df9f20fd/update_manager/boxed_value_unittest.cc
[modify] https://crrev.com/31aefb9f77cb237594e7af599b32ec93df9f20fd/update_manager/chromeos_policy_unittest.cc
[modify] https://crrev.com/31aefb9f77cb237594e7af599b32ec93df9f20fd/update_manager/boxed_value.cc
[modify] https://crrev.com/31aefb9f77cb237594e7af599b32ec93df9f20fd/update_manager/enterprise_device_policy_impl.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33a1c91bc0db648e709a3d07c97c1301dcc43792

commit 33a1c91bc0db648e709a3d07c97c1301dcc43792
Author: Marton Hunyady <hunyadym@chromium.org>
Date: Fri Aug 31 19:55:36 2018

Rename policy values of DeviceRollbackToTargetVersion

Rename the following values for better understanding and
consistency:
- RollbackWithFullPowerwash to RollbackAndPowerwash
- RollbackWithRestoreOnly to RollbackOnlyIfRestorePossible

Bug:  878736 
Change-Id: Ia617d4e6402b3ad5cd5a0791735160b8dbe593b3
Reviewed-on: https://chromium-review.googlesource.com/1196376
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Marton Hunyady <hunyadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588134}
[modify] https://crrev.com/33a1c91bc0db648e709a3d07c97c1301dcc43792/components/policy/proto/chrome_device_policy.proto
[modify] https://crrev.com/33a1c91bc0db648e709a3d07c97c1301dcc43792/components/policy/resources/policy_templates.json

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/aosp/platform/system/update_engine/+/d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b

commit d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b
Author: Marton Hunyady <hunyadym@chromium.org>
Date: Fri Aug 31 22:08:48 2018

update_engine: Rename policy values of DeviceRollbackToTargetVersion

Rename the following values for better understanding and
consistency:
- RollbackWithFullPowerwash to RollbackAndPowerwash
- RollbackWithRestoreOnly to RollbackOnlyIfRestorePossible

BUG= chromium:878736 
TEST='cros_run_unit_tests --board=caroline --packages update_engine'

Change-Id: Ib4129d2c297697e850d3027d35599fc37e104b0e
Reviewed-on: https://chromium-review.googlesource.com/1198533
Commit-Ready: Marton Hunyady <hunyadym@chromium.org>
Tested-by: Marton Hunyady <hunyadym@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>

[modify] https://crrev.com/d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b/update_manager/rollback_prefs.h
[modify] https://crrev.com/d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b/update_manager/enterprise_device_policy_impl.cc
[modify] https://crrev.com/d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b/update_manager/real_device_policy_provider_unittest.cc
[modify] https://crrev.com/d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b/update_manager/boxed_value_unittest.cc
[modify] https://crrev.com/d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b/update_manager/chromeos_policy_unittest.cc
[modify] https://crrev.com/d4bc462dc64e6ca07958e84a1ebca5ff97dbea4b/update_manager/boxed_value.cc

Status: Fixed (was: Started)
Cc: zentaro@chromium.org
Owner: ----
Hi Zentaro,

Would you happen to know when the "save and restore" feature will be available on ChromeOs devices? We would need this feature exposed in order to verify these new values.
You won't be able to test these until 73.

Comment 8 by vaandres@google.com, Jan 18 (4 days ago)

Hi Zentaro @ Has the restore feature been made available in M73 yet? I dont see any new policies in yaps.

Thanks



Sign in to add a comment