Regression: Two password entries are seen on save password bubble when auto generated password is selected.
Reported by
pranjali...@etouch.net,
Aug 29
|
|||||
Issue descriptionChrome version : 69.0.3497.72 (Official Build) 5436874581c1838dd38d9be331791e79797fa30c-refs/branch-heads/3497@{#834}(32/64 bit) OS: Windows(7,8,8.1.10) , Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS). Precondition: 1. Sign into chrome with valid username and password. 2. Enable 'Automatic password generation' flag from 'chrome://flags' . What steps will reproduce the problem? 1.Launch chrome and navigate to 'https://www.facebook.com/' . 2. choose auto generated password and Click on 'Key' icon(i.e password key icon) on omnibox and click on 'Google Account' link on save password bubble. 4. Again navigate back to previous tab (i.e 'https://www.facebook.com/) and click on 'Key' icon on omnibox. 5. Observe. Actual :Two password entries are seen on save password bubble when auto generated password is selected. Expected: Only one password entry should be seen on save password bubble when auto generated password is selected. This is a regression issue broken in ‘M-68’ and using per-revision bisect providing the bisect results, Good Build :67.0.3396.0 Bad Build: 68.0.3397.0 You are probably looking for a change made after 550556 (known good), but no later than 550557 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/860f4fd3c055b3c0cf66e29cd19a203c8863425a..bac8bac2098092cda46c8214787c467e11e40e49 Suspect: https://chromium.googlesource.com/chromium/src/+/bac8bac2098092cda46c8214787c467e11e40e49 @cfroussios: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
Sep 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30cfcbcf45f2fed4446e5cc477884f2c1b7905d2 commit 30cfcbcf45f2fed4446e5cc477884f2c1b7905d2 Author: Christos Froussios <cfroussios@chromium.org> Date: Tue Sep 04 13:17:37 2018 [Password Manager] Only consider best matches in the bubble on automatic save Previously, the bubble would merge the pending credentials into the password list too. However, the pending credentials are not guaranteed to have a valid primary key, which results in duplicates and ineffective rows, particularily when a password is generated. Bug: 878729 Change-Id: I68da172ce02a21a5127132d291c68ddfbf017999 Reviewed-on: https://chromium-review.googlesource.com/1202283 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#588498} [modify] https://crrev.com/30cfcbcf45f2fed4446e5cc477884f2c1b7905d2/chrome/browser/ui/passwords/manage_passwords_state.cc [modify] https://crrev.com/30cfcbcf45f2fed4446e5cc477884f2c1b7905d2/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc [modify] https://crrev.com/30cfcbcf45f2fed4446e5cc477884f2c1b7905d2/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
,
Sep 6
,
Sep 6
r588498 has been on trunk for a couple of days. No problems reported. Can we merge it into 70?
,
Sep 7
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f121855126ad29ea5c238147a7c5eaf60a6160da commit f121855126ad29ea5c238147a7c5eaf60a6160da Author: Christos Froussios <cfroussios@chromium.org> Date: Fri Sep 07 08:43:12 2018 [Password Manager] Only consider best matches in the bubble on automatic save Previously, the bubble would merge the pending credentials into the password list too. However, the pending credentials are not guaranteed to have a valid primary key, which results in duplicates and ineffective rows, particularily when a password is generated. Bug: 878729 Change-Id: I68da172ce02a21a5127132d291c68ddfbf017999 Reviewed-on: https://chromium-review.googlesource.com/1202283 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#588498}(cherry picked from commit 30cfcbcf45f2fed4446e5cc477884f2c1b7905d2) Reviewed-on: https://chromium-review.googlesource.com/1212847 Reviewed-by: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#128} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/f121855126ad29ea5c238147a7c5eaf60a6160da/chrome/browser/ui/passwords/manage_passwords_state.cc [modify] https://crrev.com/f121855126ad29ea5c238147a7c5eaf60a6160da/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc [modify] https://crrev.com/f121855126ad29ea5c238147a7c5eaf60a6160da/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 Deleted