New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878709 link

Starred by 1 user
Status: Fixed
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Closed: Sep 4
Cc:
yyushkina@chromium.org
pnangunoori@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[NTP]Blue focus ring is seen on clicking 'Done' button even when it is disabled

Reported by vineetha...@etouch.net, Aug 29 
Chrome version : 69.0.3497.72 (Official Build) Revision	5436874581c1838dd38d9be331791e79797fa30c-refs/branch-heads/3497@{#834}(32/64-bit) 
OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)  OS

Pre-condition: Enable "Enable using the Google local NTP" ,"New Tab Page Background Selection" flags under chrome://flags.

Steps to reproduce:
1. Launch chrome and open NTP.
2. Press tab key till focus reaches 'Gear' icon and press enter. 
3. Choose 'Chrome backgrounds' option by pressing enter to open 'Select a collection' overlay.
4. Press tab and observe that focus travels throughout overlay but not on 'Done' button as it is disabled.
5. Now try clicking the 'Done' button and observe focus ring.

Actual Result  :Blue focus ring is seen on clicking 'Done' even when it is disabled.
Expected Result:Blue focus ring should not be seen on 'Done' after clicking it when it is disabled.

This is a non regression issue seen from ‘M-69’.

Note: The issue is reproducible only after we press tab key atleast once on the 'Select a collection' overlay.
ActualVideo.mp4
626 KB View Download

Comment 1 by yyushkina@chromium.org, Aug 30

Labels: -Pri-2 Pri-3
Owner: sweilun@chromium.org
Weilun - could you take a look?

Comment 2 by yyushkina@chromium.org, Aug 30

Cc: yyushkina@chromium.org

Comment 3 by sweilun@chromium.org, Aug 30

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9731ff2ff9cedaa556fbed272f29bce828c7ee4

commit f9731ff2ff9cedaa556fbed272f29bce828c7ee4
Author: Weilun Shi <sweilun@chromium.org>
Date: Sat Sep 01 03:24:33 2018

[NTP] Remove focus ring when done button is disabled

Remove focus ring on custom background dialog's done button when it is
disabled.

Bug:  878709 
Change-Id: I9f30a27361682a6bb91273ae43cf97e1b1030594
Reviewed-on: https://chromium-review.googlesource.com/1196165
Commit-Queue: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588258}
[modify] https://crrev.com/f9731ff2ff9cedaa556fbed272f29bce828c7ee4/chrome/browser/resources/local_ntp/custom_backgrounds.css
[modify] https://crrev.com/f9731ff2ff9cedaa556fbed272f29bce828c7ee4/chrome/browser/resources/local_ntp/custom_backgrounds.js

Comment 5 by vineetha...@etouch.net, Sep 3

Labels: TE-Verified-M71 TE-Verified-71.0.3541.0
Update :
Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)OS with Canary version #71.0.3541.0 and the issue is fixed.

Kindly refer the attached screen cast.
CanaryBehaviour.mp4
680 KB View Download

Comment 6 by twelling...@chromium.org, Sep 4

Labels: zine-triaged

Comment 7 by sweilun@chromium.org, Sep 4

Status: Fixed (was: Started)

Comment 8 by ramyan@chromium.org, Sep 10

Labels: AddToRemoteNTP
►

Sign in to add a comment