dropdown render error after scrolling in multi level iframes. (only works 2nd or 3nd click)
Reported by
panznavi...@gmail.com,
Aug 29
|
|||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Steps to reproduce the problem: 1. https://data.phpartner.hu/chrome_test.php (sample) 2. Scroll the innermost iframe scrollbar to the select box and open, it will work 3. After it, scroll the outmost scrollbal down and open the dropdown, it will appear wrong place. What is the expected behavior? Select dropdown appear the right place. What went wrong? When put an iframe in an other frame, and scroll the innermost frame to a select box and open, it will works, but after if scroll the page down the dropbox will be open wrong place (lower depends on previous scroll distance) Did this work before? N/A Chrome version: 68.0.3440.106 Channel: stable OS Version: 10.0 Flash Version:
,
Aug 29
,
Aug 30
Thanks for filing the issue! Unable to reproduce the issue on reported chrome version 68.0.3440.106 using Windows 10 with the below mentioned steps. 1. Launched Chrome 2. Navigated to https://data.phpartner.hu/chrome_test.php 3. Scrolled outermost scrollbar then selected the dropdown. The positioning of the dropdown was proper, attaching the screen cast of the same for reference. @Reporter: Could you please have a look at the screen cast and let us know if we have missed anything in the process. Any further inputs from your end may be helpful.
,
Aug 30
I can reproduce this issue with "--site-per-process" enabled on M70.
,
Aug 30
Thanks for the report! And yes, I can repro as well on Windows 68.0.3440.106 and 70.0.3537.0, as well as ChromeOS 67.0.3396.99. Ken or James, can you take a look?
,
Sep 13
CL in review at https://chromium-review.googlesource.com/c/chromium/src/+/1225090, with some discussion on issue 873337 (where we might merge it). Thanks Ken!
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ee24be2aa0c578cf371f64dea1b887635959c833 commit ee24be2aa0c578cf371f64dea1b887635959c833 Author: Ken Buchanan <kenrb@chromium.org> Date: Thu Sep 13 20:29:27 2018 Propagate window positions down OOPIF chains A regression from earlier this year affected visual state updates when they are being propagated to OOPIFs, such that they don't immediately also propagate to nested OOPIFs underneath a direct child frame. This was causing temporary mispositioning of things like popup menus. This CL corrects the flaw. It also fixes a bug in a test helper class, ShowWidgetMessageFilter, which incorrectly discards information from messages that were called before Wait() was called. Bug: 878703 , 873337 Change-Id: I61f42eba4f6b7ab41d96a1db479bceb64ef00954 Reviewed-on: https://chromium-review.googlesource.com/1225090 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#591134} [modify] https://crrev.com/ee24be2aa0c578cf371f64dea1b887635959c833/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/ee24be2aa0c578cf371f64dea1b887635959c833/content/browser/site_per_process_hit_test_browsertest.cc [modify] https://crrev.com/ee24be2aa0c578cf371f64dea1b887635959c833/content/test/content_browser_test_utils_internal.cc [modify] https://crrev.com/ee24be2aa0c578cf371f64dea1b887635959c833/content/test/content_browser_test_utils_internal.h
,
Sep 13
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb11c04111341c75889944ea8e26b8af9c9a97d3 commit fb11c04111341c75889944ea8e26b8af9c9a97d3 Author: Ken Buchanan <kenrb@chromium.org> Date: Thu Sep 13 21:01:58 2018 Propagate window positions down OOPIF chains A regression from earlier this year affected visual state updates when they are being propagated to OOPIFs, such that they don't immediately also propagate to nested OOPIFs underneath a direct child frame. This was causing temporary mispositioning of things like popup menus. This CL corrects the flaw. It also fixes a bug in a test helper class, ShowWidgetMessageFilter, which incorrectly discards information from messages that were called before Wait() was called. Bug: 878703 , 873337 Change-Id: I61f42eba4f6b7ab41d96a1db479bceb64ef00954 Reviewed-on: https://chromium-review.googlesource.com/1225090 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591134}(cherry picked from commit ee24be2aa0c578cf371f64dea1b887635959c833) Reviewed-on: https://chromium-review.googlesource.com/1225602 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/branch-heads/3551@{#4} Cr-Branched-From: 08c03be7fdeabd63de8e4efca4c562a2f5a70ba9-refs/heads/master@{#590850} [modify] https://crrev.com/fb11c04111341c75889944ea8e26b8af9c9a97d3/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/fb11c04111341c75889944ea8e26b8af9c9a97d3/content/browser/site_per_process_hit_test_browsertest.cc [modify] https://crrev.com/fb11c04111341c75889944ea8e26b8af9c9a97d3/content/test/content_browser_test_utils_internal.cc [modify] https://crrev.com/fb11c04111341c75889944ea8e26b8af9c9a97d3/content/test/content_browser_test_utils_internal.h
,
Sep 14
Note: The original repro page isn't working anymore, but Nasko put together another test case at http://web.evilbit.io/frame_sizing.html. Ken verified the fix on 71.0.3552.2 in issue 873337 .
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8544c2740b0d78c5fad7637473fecb39b39dfb1 commit e8544c2740b0d78c5fad7637473fecb39b39dfb1 Author: Ken Buchanan <kenrb@chromium.org> Date: Fri Sep 14 17:41:15 2018 Propagate window positions down OOPIF chains A regression from earlier this year affected visual state updates when they are being propagated to OOPIFs, such that they don't immediately also propagate to nested OOPIFs underneath a direct child frame. This was causing temporary mispositioning of things like popup menus. This CL corrects the flaw. It also fixes a bug in a test helper class, ShowWidgetMessageFilter, which incorrectly discards information from messages that were called before Wait() was called. Bug: 878703 , 873337 Change-Id: I61f42eba4f6b7ab41d96a1db479bceb64ef00954 Reviewed-on: https://chromium-review.googlesource.com/1225090 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591134}(cherry picked from commit ee24be2aa0c578cf371f64dea1b887635959c833) Reviewed-on: https://chromium-review.googlesource.com/1226027 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#406} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/e8544c2740b0d78c5fad7637473fecb39b39dfb1/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/e8544c2740b0d78c5fad7637473fecb39b39dfb1/content/browser/site_per_process_hit_test_browsertest.cc [modify] https://crrev.com/e8544c2740b0d78c5fad7637473fecb39b39dfb1/content/test/content_browser_test_utils_internal.cc [modify] https://crrev.com/e8544c2740b0d78c5fad7637473fecb39b39dfb1/content/test/content_browser_test_utils_internal.h
,
Sep 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47b99a368e694ae38346630ce4c621622de4b8b0 commit 47b99a368e694ae38346630ce4c621622de4b8b0 Author: Ken Buchanan <kenrb@chromium.org> Date: Fri Sep 14 17:40:27 2018 Propagate window positions down OOPIF chains A regression from earlier this year affected visual state updates when they are being propagated to OOPIFs, such that they don't immediately also propagate to nested OOPIFs underneath a direct child frame. This was causing temporary mispositioning of things like popup menus. This CL corrects the flaw. It also fixes a bug in a test helper class, ShowWidgetMessageFilter, which incorrectly discards information from messages that were called before Wait() was called. Bug: 878703 , 873337 Change-Id: I61f42eba4f6b7ab41d96a1db479bceb64ef00954 Reviewed-on: https://chromium-review.googlesource.com/1225090 Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#591134}(cherry picked from commit ee24be2aa0c578cf371f64dea1b887635959c833) Reviewed-on: https://chromium-review.googlesource.com/1226026 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#937} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/47b99a368e694ae38346630ce4c621622de4b8b0/content/browser/frame_host/cross_process_frame_connector.cc [modify] https://crrev.com/47b99a368e694ae38346630ce4c621622de4b8b0/content/browser/site_per_process_hit_test_browsertest.cc [modify] https://crrev.com/47b99a368e694ae38346630ce4c621622de4b8b0/content/test/content_browser_test_utils_internal.cc [modify] https://crrev.com/47b99a368e694ae38346630ce4c621622de4b8b0/content/test/content_browser_test_utils_internal.h |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by cbiesin...@chromium.org
, Aug 29