New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878697 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature
M70

Blocking:
issue 840703



Sign in to add a comment

Autofill wallet USS bridge should drop addresses in ephemeral mode

Project Member Reported by jkrcal@chromium.org, Aug 29

Issue description

For v1, the bridge for the ephemeral mode should not store server addresses.
 
Labels: -Type-Bug Type-Feature
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251

commit bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251
Author: Jan Krcal <jkrcal@chromium.org>
Date: Thu Aug 30 09:16:01 2018

[AF Wallet] Drop server addresses when in ephemeral mode

After this CL, the autofill wallet data bridge drops server addresses
when in ephemeral mode. This required to plumb in the information
whether the given bridge instance operates in the full-sync mode or in
the ephemeral mode.

Bug:  878697 
Change-Id: I61a6fb047b47068509215a9a80d9fcde1b2212f2
Reviewed-on: https://chromium-review.googlesource.com/1193933
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587491}
[modify] https://crrev.com/bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251/components/autofill/core/browser/webdata/autofill_sync_bridge_util.cc
[modify] https://crrev.com/bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251/components/autofill/core/browser/webdata/autofill_sync_bridge_util.h
[modify] https://crrev.com/bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc
[modify] https://crrev.com/bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h
[modify] https://crrev.com/bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc
[modify] https://crrev.com/bebe60c5d3ddbdda75b8c10ebf23a7dc6b9b4251/components/webdata_services/web_data_service_wrapper.cc

Blocking: 840703
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/618b687345db2caead2b515e5317150cd7955a77

commit 618b687345db2caead2b515e5317150cd7955a77
Author: Jan Krcal <jkrcal@chromium.org>
Date: Thu Aug 30 13:46:34 2018

[AF Wallet] Notify changes in PaymentsCustomerData to WebDataBackend

AutofillWalletSyncBridge did not notify changes in PaymentsCustomerData
to WebDataBackend. This was a bug because PersonalDataManager relies on
such notifications.

This CL fixes the bug (and also aligns the behaviour of the bridge to
to other wallet data so that it writes changes only when needed).

Bug:  878697 
Change-Id: Id69c0520f192e401380c1eb2dbd55d28f25770b6
Reviewed-on: https://chromium-review.googlesource.com/1196382
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587552}
[modify] https://crrev.com/618b687345db2caead2b515e5317150cd7955a77/components/autofill/core/browser/payments/payments_customer_data.h
[modify] https://crrev.com/618b687345db2caead2b515e5317150cd7955a77/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.cc
[modify] https://crrev.com/618b687345db2caead2b515e5317150cd7955a77/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge.h
[modify] https://crrev.com/618b687345db2caead2b515e5317150cd7955a77/components/autofill/core/browser/webdata/autofill_wallet_sync_bridge_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment