New issue
Advanced search Search tips

Issue 878696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

isConnected() not cleared for MediaControlsImpl

Project Member Reported by futhark@chromium.org, Aug 29

Issue description

Missing call to base class RemovedFrom().

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ccd5c888fed170f998921f5db937d962cae9b82

commit 2ccd5c888fed170f998921f5db937d962cae9b82
Author: Rune Lillesveen <futhark@chromium.org>
Date: Wed Aug 29 22:39:06 2018

Call base class RemovedFrom for MediaControlsImpl.

isConnected() bit was not correctly cleared because of this.

Bug:  878696 
Change-Id: I09d69c94eb5f9c9f4694a6ff1a473a112c895c8d
Reviewed-on: https://chromium-review.googlesource.com/1194225
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587341}
[modify] https://crrev.com/2ccd5c888fed170f998921f5db937d962cae9b82/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
[modify] https://crrev.com/2ccd5c888fed170f998921f5db937d962cae9b82/third_party/blink/renderer/modules/media_controls/media_controls_impl_test.cc

Status: Fixed (was: Started)

Sign in to add a comment