bh@ Thanks for the issue.

Tested this issue on Ubuntu 17.10 on the reported version 68.0.3440.106 and unable to reproduce the issue by following the below steps.
Launched Chrome and hit the Ctrl + mousewheel on touchpad (ie two fingers sliding up or down), can observe that the page is zoomed in and out as expected.

As this issue is reported on Ubuntu 18.04.1, adding 'TE-NeedsTriageFromHYD' label and requesting Inhouse team to look into the issue and help in further triaging.

Thanks..

I hope this can help the triage :

On the same machine
-------------------

* Ubuntu 18.04 LTS and chrome Version 67.0.3396.99 (Build officiel) (64 bits) ==> it works

* update Ubuntu to 18.04.1 LTS and chrome to Version 68.0.3440.106 (Build officiel) (64 bits) ==> it does not work

* let Ubuntu at 18.04.1 LTS but downgrade chrome to 65.0.3325.181 ==> it works

As we are unable to reproduce the issue on Ubuntu 17.10 on the reported version 68.0.3440.106 as per C#2, as issue reported on Ubuntu 18.04 & Google-HYD team do not have Ubuntu 18.04 machine with us,routing to MTV team to take a look into this issue. Adding 'TE-NeedsTriageFromMTV' for further triaging.

Thanks.

Susan, please download Ubuntu 18.04 and triage further.

ligimole@ Sure, have raised a ticket with local N/W team for upgrade of OS from Ubuntu 17.10 to Ubuntu 18.04.
Will update the behavior once OS 18.04 is available.

Thanks..

// Adding to comment #6.

Tried to upgraded one linux system to Ubuntu 18.04, but unable to do the build download setup as we are getting the error "Python 3 and later is not compatible with Google Cloud SDK".
When we tried to downgrade the python version to 2.7.x, the whole system got corrupted and had to reinstall the OS again. Hence unable to test this issue on Ubuntu 18.04.

Hence tentatively adding 'Internals>Input>Touch>Pad' component and adding 'TE-NeedsTriageFromMTV label for help in further triaging of this issue.

Thanks..

Also experiencing this on Arch Linux, ctrl+mousewheel zooms correctly but ctrl+touchpad scrolls

Chrome Version 69.0.3497.92 (Official Build) (64-bit)

Same problem here for the past few months: Ctrl+Two-finger-scroll-on-touchpad stopped working on Chrome; it now just scrolls instead of zooms. Zooming that way with the touchpad still works fine in other applications.

If I plug in a mouse, Ctrl+Mouse-wheel zooming works in Chrome, so it must be something related to touchpads...and Chrome. 

Chrome 69 (and other recent versions)

Fedora 27 (KDE)

Linux 4.17.11

libinput-1.10.5 (old school)

Lenovo Thinkpad T520

Confirmed for Chrome Version 69.0.3497.100 (Official Build) (64-bit) on Fedora 28.

Ctrl + Touchpad does not zoom but scrolls instead.

That used to work previously.

Yours

An update to my earlier comment #9:

I use the old Synaptics driver (xorg-x11-drv-synaptics-legacy, v. 1.9.0) for my touchpad. (I found libinput to be hopelessly broken in far too many ways.)

Ctrl+Two-finger-scroll-on-touchpad works fine in Chrome's print preview, just not on web pages.

I can confirm that Ctrl + touchpad zoom works with PDFs.

Just tested on http://www.orimi.com/pdf-test.pdf.

I too have observed that CTRL + Touchpad does not work for zooming on Chrome since updating to version 68 on Fedora 28.

Same here with a 69 version (69.0.3497.100): CTRL + Touchpad does not control zoom!

(years ago it was the CTRL + SHIFT + zoom-in shortkey which disappear: https://bugs.chromium.org/p/chromium/issues/detail?id=414110)

Same issue with Chromium Version 69.0.3497.81 (Official Build) Built on Ubuntu and Version 69.0.3497.100 (Official Build) (64-bit)
running on Ubuntu 18.04 (64-bit).
In Firefox the ctrl+ touchpad scroll works like it used to work for chromium

Same here here (ctrl + 2-finger-scroll not working anymore), ctrl + mouse wheel scroll zooming works, however.
Interesting: ctrl+p (print preview): here zooming works.

System:
- arch linux
- Chromium: 70.0.3538.67 (Official Build) Arch Linux (64-bit)
- Synaptics: local/xf86-input-synaptics 1.9.1-1 (xorg-drivers)

content of:
/usr/share/X11/xorg.conf.d/70-synaptics.conf:

# Example xorg.conf.d snippet that assigns the touchpad driver
# to all touchpads. See xorg.conf.d(5) for more information on
# InputClass.
# DO NOT EDIT THIS FILE, your distribution will likely overwrite
# it when updating. Copy (and rename) this file into
# /etc/X11/xorg.conf.d first.
# Additional options may be added in the form of
#   Option "OptionName" "value"
#
Section "InputClass"
        Identifier "touchpad catchall"
        Driver "synaptics"
        MatchIsTouchpad "on"
# This option is recommend on all Linux systems using evdev, but cannot be
# enabled by default. See the following link for details:
# http://who-t.blogspot.com/2010/11/how-to-ignore-configuration-errors.html
#       MatchDevicePath "/dev/input/event*"
EndSection

Section "InputClass"
        Identifier "touchpad ignore duplicates"
        MatchIsTouchpad "on"
        MatchOS "Linux"
        MatchDevicePath "/dev/input/mouse*"
        Option "Ignore" "on"
EndSection

# This option enables the bottom right corner to be a right button on clickpads
# and the right and middle top areas to be right / middle buttons on clickpads
# with a top button area.
# This option is only interpreted by clickpads.
Section "InputClass"
        Identifier "Default clickpad buttons"
        MatchDriver "synaptics"
        Option "SoftButtonAreas" "50% 0 82% 0 0 0 0 0"
        Option "SecondarySoftButtonAreas" "58% 0 0 15% 42% 58% 0 15%"
EndSection

# This option disables software buttons on Apple touchpads.
# This option is only interpreted by clickpads.
Section "InputClass"
        Identifier "Disable clickpad buttons on Apple touchpads"
        MatchProduct "Apple|bcm5974"
        MatchDriver "synaptics"
        Option "SoftButtonAreas" "0 0 0 0 0 0 0 0"
EndSection

I can confirm that zooming doesn't work as it worked before (16.04).

Ubuntu 18.04.1 LTS
Version 70.0.3538.67 (Official Build) (64-bit)

Linux debian 4.9.0-8-amd64 #1 SMP Debian 4.9.130-2 (2018-10-27) x86_64 GNU/Linux
Chrome Version 70.0.3538.77 (Official Build) (64-bit)

Same issue with X11. It works well with Wayland.

Oh really? That's interesting. Can someone else confirm that zooming in
with the touchpad + Ctrl does work on Wayland but not on X11?

I can't reproduce on my machine.  For anyone hitting this issue: please try a bisect.  Bisecting takes only a few minutes and doesn't require a Chromium checkout.  Here are the steps:

$ curl -s --basic -n "https://chromium.googlesource.com/chromium/src/+/master/tools/bisect-builds.py?format=TEXT" | base64 -d > bisect-builds.py
$ python bisect-builds.py --use-local-cache -a linux64 -g 450000 -- --user-data-dir=/tmp/`uuidgen` --no-first-run

Then indicate if each build is (g)ood or (b)ad and post the results.

bisect result:
--------------

You are probably looking for a change made after 554473 (known good), but no later than 554497 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/c3c9a833de2f7cf46f50dd8b1bb2eaf048978a27..f96c536d35a66a07cb267de42c3679b2e36617f0

c#23 thanks!  I'm seeing 3 changes in that revision range related to scrolling:

71f09952 Autoscroll has priority over wheel scrolling. by sahel · 6 months ago
a71865a Convert Linux touchpad event to Scroll event by chaopeng · 6 months ago
9170bc2 Prevent recursion in FrameLoader::RestoreScrollPositionAndViewState by Stefan Zager · 6 months ago

+CL authors PTAL

Chaopeng@ do you think it might be related to https://chromium-review.googlesource.com/988748 ?

Yes, this behavior is change on https://chromium-review.googlesource.com/988748 because we set precise delta flag for touchpad on Linux now. Now ctrl + touchpad scroll expected not zoom but only scroll same as touchpad on Windows and Mac.

If you need zoom in/out without mouse you need to use ctrl + =.

This feels like a regression. Why not still support it?

1. keeping same behavior on different platforms
2. Linux touchpad has fling + ctrl zoom issue ( Bug 599497 )

Is there at least a setting to re-enable it? Years old muscle memory gained in this and many other applications punishes me when the expected action does not happen.

+ bokan

David, Do you think we should add a flag allow user back to old behavior?

1. We don't support pinch zoom on Linux Touchpad, I think that is why user request re-enable ctrl + touchpad scroll here.
2. Bug 867821

 Issue 900106  has been merged into this issue.

Re#30: This is just for "high-precision" touchpads, real mouse-wheels still cause ctrl+zoom, correct? If so, I think the current behavior is WAI, I don't think it ever makes sense to use a high precision touchpad to do _browser_ zoom (it'd be nice if we could do pinch-zoom from Linux trackpads but that's likely a lot of work).

We tend to avoid flags unless absolutely necessary. Given there's an easy alternative (ctrl+/-) and it's like this on other platforms I don't think we should add one. 

I'm not convinced that it is WAI and if it is WAI, I'm not sure it makes sense. 
I can scroll on my wheel mouse and I can scroll on my touchpad 
I can ctrl scroll to zoom on my wheel mouse but I can NOT ctrl scroll to zoom on my touchpad.

Not really intuitive to me.

Regarding considering ctrl +/- an easy alternative I'm not convinced either. On certain KB layout there is no + sign so you end up perssing a 3 finger combination (ctrl shift 1) on a laptop just to do something (zoom in) that was existing is really frustrating. oh and by the way on my X1 carbon with ubuntu 18.04 this does not work (brobably a different bug). I've to zoom out with ctrl - and then use the mouse to click on the little +/- icons that appear.

So currently I've to use FF because the zoom in is absolutely unusable for me.

> I can ctrl scroll to zoom on my wheel mouse but I can NOT ctrl scroll to zoom on my touchpad.

A wheel has discrete steps whereas a high-precision touchpad is continuous. Zooming happens in discrete jumps so it doesn't map well onto a high-precision touchpad.

> X1 carbon with ubuntu 18.04 this does not work (brobably a different bug)

I've not heard of any issues with keyboard based zooming. Please file a separate bug and we can investigate.

I have the same issue and would also really appreciate at least having an option to turn it back on.  I use ctrl and the touchpad to handle zoom on pretty much everything else in Linux without any problems, and did so previously on Chrome before this change.  Making Chrome behave differently than almost all the other apps on an OS does not make sense imho.

Thanks!

With a qwertz laptop keyboard (no numeric pad) hitting 'ctrl +' doesn't works but 'ctrl -' works for unzooming...

Now, on firefox 'ctrl +/-' and 'ctrl touch pad scroll' works and it's much much practical on a latop...

Ctrl + TP-Scroll works in essentially every other program that supports zooming. It is simple, intuitive, and consistent. It doesn't require moving your hand to the keyboard, and most web browsing is done with a hand on the mouse.

Furthermore, as mentioned above, this change introduces a blatant inconsistency with Ctrl+Mouse-Scroll. This is unexpected and should absolutely be considered a regression.

I think it is very misguided to remove this standard functionality.

Just to add that the comment about "keeping same behavior on different platforms" doesn't ring true, as Ctrl+c, Ctrl+v etc do not work on MacOS, instead the platform norms apply (Cmd+c, Cmd+v etc)

Even stranger, the Ctrl-trackpad scroll does zoom in the print preview (as mentioned in a post in this thread), *and* when viewing a PDF file, but not when viewing a web page.

This is extremely inconsistent.

A quick test with a Thinkpad Helix with dual boot and Chrome version 71.0.3578.98: On Windows 10 ctrl + two-finger-touchpad-scroll results in zooming and on the same machine with Ubuntu 18.04.1 LTS ctrl + two-finger-touchpad-scroll results in scrolling. 
I don't see how this is "keeping same behavior on different platforms"

On a side note, I also don't think that "ctrl+/-" is an easy alternative especially since on many international keyboard layouts (without Numpad) the + is not a dedicated key. Eg on the Swiss keyboard layout, the "+" is accessed by the combination shift+1 but the combination  ctrl+shift+1 does nothing and thus does not result in zooming in, so there is basically no easy way (that I know of) to zoom in.

Very unfortunate to see this ticket in Closed/WontFix, especially when it seems like there is still a question about what the behavior is in Linux compared to Windows and Mac.

In response to the comment made about high precision touchpads not mapping well to stepped scrolling, it seemed to have worked without any issues prior to release 68. What has changed to make the mapping a problem?