Chrome Version: since 2012 (landed https://codereview.chromium.org/11444013)
OS: Windows




Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 

Chrome Version: since 2012 (landed https://codereview.chromium.org/11444013)
OS: Windows only

What steps will reproduce the problem?
We can reproduce it simply with unit test if adding the below code at os_exchange_data_win_unittest.cc

'''
TEST(OSExchangeDataWinTest, Filenames) {
  OSExchangeData data;
  const std::vector<FileInfo> kTestFilenames = {
      {base::FilePath(FILE_PATH_LITERAL("/tmp/test_file1")),
       base::FilePath()},
      {base::FilePath(FILE_PATH_LITERAL("/tmp/test_file2")),
       base::FilePath()},
  };
  data.SetFilenames(kTestFilenames);

  OSExchangeData copy(data.provider().Clone());
  std::vector<FileInfo> dropped_filenames;

  EXPECT_TRUE(copy.GetFilenames(&dropped_filenames));
  EXPECT_EQ(kTestFilenames, dropped_filenames);
}
'''

I attached also the modified file.

Why?
For dragging multiple files, we should have one CF_HDROP having the multiple file paths.
(CF_HDROP clipboard format consists of DROPFILES structure, a series of file names including the terminating NULL character and the additional null character at the tail to terminate the array.
see https://docs.microsoft.com/ko-kr/windows/desktop/shell/clipboard#cf_hdrop)
But we have multiple CF_HDROPs having a file path.

What is the expected result?
PASS

What happens instead?
FAIL


Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.


 

Chrome Version: since 2012 (landed https://codereview.chromium.org/11444013)
OS: Windows only

What steps will reproduce the problem?
We can reproduce it simply with unit test if adding the below code at os_exchange_data_win_unittest.cc

'''
TEST(OSExchangeDataWinTest, Filenames) {
  OSExchangeData data;
  const std::vector<FileInfo> kTestFilenames = {
      {base::FilePath(FILE_PATH_LITERAL("/tmp/test_file1")),
       base::FilePath()},
      {base::FilePath(FILE_PATH_LITERAL("/tmp/test_file2")),
       base::FilePath()},
  };
  data.SetFilenames(kTestFilenames);

  OSExchangeData copy(data.provider().Clone());
  std::vector<FileInfo> dropped_filenames;

  EXPECT_TRUE(copy.GetFilenames(&dropped_filenames));
  EXPECT_EQ(kTestFilenames, dropped_filenames);
}
'''

I attached also the modified file.

Why?
For dragging multiple files, we should have one CF_HDROP having the multiple file paths.
(CF_HDROP clipboard format consists of DROPFILES structure, a series of file names including the terminating NULL character and the additional null character at the tail to terminate the array.
see https://docs.microsoft.com/ko-kr/windows/desktop/shell/clipboard#cf_hdrop)
But we have multiple CF_HDROPs having a file path.

What is the expected result?
PASS

What happens instead?
FAIL

 

Chrome Version: since 2012 (landed the patch at https://codereview.chromium.org/11444013)
OS: Windows only

What steps will reproduce the problem?
We can reproduce it simply with unit test if adding the below code at os_exchange_data_win_unittest.cc

'''
TEST(OSExchangeDataWinTest, Filenames) {
  OSExchangeData data;
  const std::vector<FileInfo> kTestFilenames = {
      {base::FilePath(FILE_PATH_LITERAL("/tmp/test_file1")),
       base::FilePath()},
      {base::FilePath(FILE_PATH_LITERAL("/tmp/test_file2")),
       base::FilePath()},
  };
  data.SetFilenames(kTestFilenames);

  OSExchangeData copy(data.provider().Clone());
  std::vector<FileInfo> dropped_filenames;

  EXPECT_TRUE(copy.GetFilenames(&dropped_filenames));
  EXPECT_EQ(kTestFilenames, dropped_filenames);
}
'''

I attached also the modified file.

Why?
For dragging multiple files, we should have one CF_HDROP having the multiple file paths.
(CF_HDROP clipboard format consists of DROPFILES structure, a series of file names including the terminating NULL character and the additional null character at the tail to terminate the array.
see https://docs.microsoft.com/ko-kr/windows/desktop/shell/clipboard#cf_hdrop)
But we have multiple CF_HDROPs having a file path.

What is the expected result?
PASS

What happens instead?
FAIL