New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878679 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Add 'quarter' data back to the ICU data

Project Member Reported by ftang@chromium.org, Aug 29

Issue description

Currently src/third_party/icu/scripts/trim_data.sh strip off the "quarter" data and prevent us from a complete fix of format with "quarter" in Intl.RelativeDateTimeFormatter.

We need to change the script src/third_party/icu/scripts/trim_data.sh and regenerated the data (When a newer version of ICU have the patch https://github.com/unicode-org/icu/pull/77/

src/third_party/icu/scripts/trim_data.sh

  # Remove entries currently not used in Chromium/V8.
  function filter_locale_data {
    echo Removing unncessary categories in ${localedatapath}
    for langpath in ${localedatapath}/*.txt
    do
      echo Overwriting ${langpath} ...
      sed -r -i \
        '/^    characterLabel\{$/,/^    \}$/d
         /^    AuxExemplarCharacters\{.*\}$/d
         /^    AuxExemplarCharacters\{$/, /^    \}$/d
         /^    ExemplarCharacters\{.*\}$/d
         /^    ExemplarCharacters\{$/, /^    \}$/d
-        /^        (mon|tue|wed|thu|fri|sat|sun|quarter)(|-short|-narrow)\{$/, /^        \}$/d' 
+        /^        (mon|tue|wed|thu|fri|sat|sun)(|-short|-narrow)\{$/, /^        \}$/d' 
  ${langpath}
    done
  }



 
Status: Assigned (was: Untriaged)
jshin- could you help to remove the "|quarter" from src/third_party/icu/scripts/trim_data.sh first?
We do not need to regenerate the icu data now since I have not landed https://github.com/unicode-org/icu/pull/77 yet. But it will be nice if we update the script first so we won't forget it when we update the new ICU release.
Components: Blink>JavaScript>Internationalization
Labels: -Pri-1 -Type-Bug Pri-2 Type-Feature
Summary: Add 'quarter' data back to the ICU data (was: ICU src/third_party/icu/scripts/trim_data.sh strip off necessary data)
Status: Fixed (was: Assigned)
Hmmm. why nothing is recorded here? Did I have a typo in the CL description? 

This issue was resolved with two CLs (one for ICU and the other for ICU DEPS roll). 
 


Sign in to add a comment