In servo, when a control is specified as follows:
<name>control_name</name>
<remap>shown_control_name</name>
it gets configured such that when you invoked shown_control_name you really invoke control_name
This can lead to confusion in two ways:
- When writing the configuration, I think it's more intuitive to have the convention flipped i.e. name should invoke remap and not remap should invoke name
- When using the control, the original control name still sticks around. If the functionality changed, it might lead to confusion.
This isn't a widely used feature:
grep -r remap | wc
6
inside servo/data
Are there any concerns with
- reversing the order
- by default removing the old control name, or if not at least giving the option side the params to say "please remove the name of the control I'm mapping to"?
Comment 1 by tbroch@chromium.org
, Aug 29Sounds fine to me. I think I like removing old control name. Looks like this feature is used quite sparingly ATM, chromeos_public src/third_party/hdctools/servo/data/warm_reset_reconf.xml 4: <name>hpd</name> 5: <remap>warm_reset</remap> 6: </control> chromeos_public src/third_party/hdctools/servo/data/servo_kukui_overlay.xml 22: <doc>cold reset used for warm reset</doc> 23: <remap>warm_reset</remap> 24: </control> chromeos_public src/third_party/hdctools/servo/data/servo_lumpy_overlay.xml 7: <name>fw_up</name> 8: <remap>rec_mode</remap> 9: </control> chromeos_public src/third_party/hdctools/servo/data/servo_stumpy_overlay.xml 10: <name>fw_up</name> 11: <remap>rec_mode</remap> 12: </control> chromeos_public src/third_party/hdctools/servo/data/servo_x86-alex_overlay.xml 7: <name>fw_up</name> 8: <remap>rec_mode</remap> 9: </control>