Issue metadata
Sign in to add a comment
|
Omnibox background contrast too low with some themes
Reported by
shruti.j...@etouch.net,
Aug 29
|
||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3497.72 (Official Build) Revision 5436874581c1838dd38d9be331791e79797fa30c-refs/branch-heads/3497@{#834}(64-bit) OS: Windows(7,8,8.1,10) Test URL:https://chrome.google.com/webstore/detail/bluegreen-cubes/iipbjjaibkibpabddphfcgbngfhhfkml?utm_source=chrome-ntp-icon Steps to reproduce: 1.Launch chrome and apply above theme on browser from above given test URL. 2.Open NTP and observe omnibox. Actual:Unable to differentiate visually between omnibox and tab-strip after applying theme. Expected:Omni-box and Tab-strip should be visually differentiable easily after applying theme. This is regression issue broken in ‘M-69’ and below is the bisect info: Good Build:69.0.3472.0 Bad Build:69.0.3473.0 Unable to provide bisect using per-revision script,Hence providing bisect with old script: Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/3c16d9d466102e0839cad4e70cea850107143ca4..64c540a750df6adb453c0f8e6e63800d8948d04c Suspect:https://chromium.googlesource.com/chromium/src/+/8a4187003e401bcb6a541427fe72fc425c5a9f1b @Allen Bauer : Could you please help to reassign if your change is not the cause for this change. Thank You. Kindly refer the attached video. Thank You!
,
Aug 30
Over to bklmn for his thoughts. I'm not sure what the latest plans are for theming and how they might related to this.
,
Aug 30
,
Aug 30
There are plans for theming, but not sure how those eng efforts are overlapped with this. When we did accessibility review we decided the OB didn't need a stroke (in general), but did darken the hover color value. If the OB can know a theme is installed it should be easy enough to define a dark color w/ opacity to help with this, but I believe themes can control text color too, so this might need more guidance from the theme folks.
,
Aug 30
monicagv@ to update on theme plans
,
Aug 30
Per our Themes 2.0 design, the Omnibox will be themed whenever a theme is installed. Not sure if we want to wait until Themes 2 is implemented to fix this? If we want to fix it sooner, perhaps we can add theme-ability to the OB and grab a theme color that makes sense when it comes to contrast?
,
Sep 6
adding label 'ET-MUM-Reported' as we need that label to track bugs.
,
Sep 11
,
Sep 20
,
Sep 24
Issue 885272 has been merged into this issue.
,
Sep 24
https://crbug.com/863591 is related.
,
Sep 26
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by pkasting@chromium.org
, Aug 29Components: -UI>Browser>TabStrip UI>Browser>Omnibox UI>Browser>Themes
Labels: -Pri-1 -hasbisect -M-69 -FoundIn-69 -FoundIn-70 -RegressedIn-69 -Target-69 -ET-MUM-Reported M-70 Pri-2
Owner: jdonnelly@chromium.org
Summary: Omnibox background contrast too low with some themes (was: Regression:Unable to differentiate visually between omnibox and tab-strip after applying theme in chrome.)