New issue
Advanced search Search tips

Issue 878652 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in content::FileSystemDispatcher::ReadDirectorySync

Project Member Reported by ClusterFuzz, Aug 29

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4536553934946304

Fuzzer: ochang_domfuzzer
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::FileSystemDispatcher::ReadDirectorySync
  content::WebFileSystemImpl::ReadDirectory
  blink::DOMFileSystemBase::ReadDirectory
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=585561:585562

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4536553934946304

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 29

Components: Blink>Storage>FileSystem
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 29

Labels: Test-Predator-Auto-Owner
Owner: adithyas@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/efface138ceef999ffe0f82b1ac54281808c154f ([FileSystem] Use mojo sync calls to block worker threads).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 29

Labels: Target-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 29

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 29

Labels: Pri-1
Cc: mek@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d909938c1000041dd64d3c29377dd3855d263078

commit d909938c1000041dd64d3c29377dd3855d263078
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Aug 30 13:53:45 2018

[FileSystem] Initialize base::File::Error variables with values

Bug:  878652 
Change-Id: Ibbf18905c3aad4160cb5476542504dc2ef30ba91
Reviewed-on: https://chromium-review.googlesource.com/1195795
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587555}
[modify] https://crrev.com/d909938c1000041dd64d3c29377dd3855d263078/content/renderer/fileapi/file_system_dispatcher.cc

Project Member

Comment 8 by ClusterFuzz, Aug 31

ClusterFuzz has detected this issue as fixed in range 587554:587555.

Detailed report: https://clusterfuzz.com/testcase?key=4536553934946304

Fuzzer: ochang_domfuzzer
Job Type: linux_msan_content_shell_drt
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  content::FileSystemDispatcher::ReadDirectorySync
  content::WebFileSystemImpl::ReadDirectory
  blink::DOMFileSystemBase::ReadDirectory
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=585561:585562
Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=587554:587555

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4536553934946304

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Aug 31

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4536553934946304 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Aug 31

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Dec 7

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment