New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878646 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: ----


Participants' hotlists:
Better-Together-Launch-Blockers


Sign in to add a comment

CrOS Setup Screen - Done screen is not upto spec

Project Member Reported by shibasheikh@chromium.org, Aug 29

Issue description

Complete screen details from Elizabeth

1. Same Google G and title issue.
2. The button should be at the bottom.
3. The image should be 16dp lower.
4. No underline for the link to settings and it should be color: GBlue 600 #1A73E8 100%

UX spec
https://docs.google.com/presentation/d/1hloC0CmSxtuwHbVLbKSaq1HWpxyYt4EDTTxMuPu0wHc/edit#slide=id.g308d9b89f8_0_95
 
Screenshot 2018-08-28 at 3.18.48 PM.png
2.2 MB View Download
Cc: shibasheikh@chromium.org elizabethchiu@chromium.org
Labels: -Restrict-View-Google -Pri-1 OS-Chrome Pri-2
Owner: jordynass@chromium.org
Labels: -M-70 M-71
Labels: -Pri-2 Pri-1
Here is the current state of the done/setup complete page on the master branch as of 9.11.18:

https://drive.google.com/open?id=0B1-cJJPK-cu6ek5tLV9GQ0ZpdTZKc0NlZXd4S0lqMEpQblFF
Thanks, Jordy. It looks like everything Shiba listed in comment #1 is still applicable on this one and it's pretty actionable. 

Comment 6 Deleted

The red line for this (https://drive.google.com/open?id=1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F) does not show a text color for the message, but it appears darker than the message in the start setup page. Do we want all the body text to be the same color or is there a separate spec for this page?

That red line also has a 'back' button, when I thought this was only supposed to have a 'done' button.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8868e9a206090922044ae8d8a79dc2b8367dc7f4

commit 8868e9a206090922044ae8d8a79dc2b8367dc7f4
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Wed Sep 19 02:04:58 2018

[CrOS MultiDevice] Setup Flow UI Styling (cont.)

Under the hood:
  -Pulled styling imports into multidevice_setup_shared_css

Visible
  -Unified default text specs
  -Placed button bar at the bottom of the page
  -Implemented some (not all) padding between elements in start setup
page

Bug:  878646 , 878644, 878643
Change-Id: I53d97060d139bcadd9594866f9342040fa386e80
Reviewed-on: https://chromium-review.googlesource.com/1232473
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592304}
[modify] https://crrev.com/8868e9a206090922044ae8d8a79dc2b8367dc7f4/chrome/browser/resources/chromeos/multidevice_setup/button_bar.html
[modify] https://crrev.com/8868e9a206090922044ae8d8a79dc2b8367dc7f4/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/8868e9a206090922044ae8d8a79dc2b8367dc7f4/chrome/browser/resources/chromeos/multidevice_setup/multidevice_setup_shared_css.html
[modify] https://crrev.com/8868e9a206090922044ae8d8a79dc2b8367dc7f4/chrome/browser/resources/chromeos/multidevice_setup/password_page.html
[modify] https://crrev.com/8868e9a206090922044ae8d8a79dc2b8367dc7f4/chrome/browser/resources/chromeos/multidevice_setup/setup_succeeded_page.html
[modify] https://crrev.com/8868e9a206090922044ae8d8a79dc2b8367dc7f4/chrome/browser/resources/chromeos/multidevice_setup/start_setup_page.html
[modify] https://crrev.com/8868e9a206090922044ae8d8a79dc2b8367dc7f4/chrome/browser/resources/chromeos/multidevice_setup/ui_page.html

Components: -UI>ProximityAuth UI>Multidevice
@Shiba, please see comment#7 by Jordy above re: text color in the spec. Thank you!
Owner: elizabethchiu@chromium.org
All body text color should be the same and no back button on the 'Done' page
Owner: jordynass@chromium.org
Jordy, it sounds like Shiba's clarifications should make this actionable from here.
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98e808cc601e21fac75b8cc49399efb3d4d0b702

commit 98e808cc601e21fac75b8cc49399efb3d4d0b702
Author: Jordy Greenblatt <jordynass@chromium.org>
Date: Wed Sep 26 20:52:34 2018

[CrOS MultiDevice] Sync setup flow font color with mocks

Note that there will be a separate CL with password page formatting
because it requires some additional tweaks.

Specs:
https://drive.google.com/file/d/1UqHV67OrdGT0_G0L98nV5IVr26OkHu9F/view?usp=sharing

New change screenshots:
Start Setup Page: http://screen/1PkWGgTYmVG
Setup Complete Page: http://screen/drwnruTOBNw

Bug:  878646 , 878644
Change-Id: Idf2afceb75dbb1c5b0157ffd8405fceea59cff46
Reviewed-on: https://chromium-review.googlesource.com/1246781
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594468}
[modify] https://crrev.com/98e808cc601e21fac75b8cc49399efb3d4d0b702/ui/webui/resources/cr_components/chromeos/multidevice_setup/multidevice_setup.html
[modify] https://crrev.com/98e808cc601e21fac75b8cc49399efb3d4d0b702/ui/webui/resources/cr_components/chromeos/multidevice_setup/start_setup_page.html
[modify] https://crrev.com/98e808cc601e21fac75b8cc49399efb3d4d0b702/ui/webui/resources/cr_components/chromeos/multidevice_setup/ui_page.html

Status: Fixed (was: Assigned)
I neglected to include this bug in https://chromium-review.googlesource.com/c/chromium/src/+/1246960 but it took care of the last formatting requirements of this page, namely fixing the margin between the message and the image and the un-bolding of the header.

Sign in to add a comment