New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878597 link

Starred by 1 user
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Aug 29
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[PIP] Toggle Play/Pause by pressing the space key

Project Member Reported by apaci...@chromium.org, Aug 28 
Toggle play/pause when the user presses the space bar. This allows users to play/pause with keyboard only without having to turn on a screen reader.

This should not affect a11y.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bcb668f7df7636cf35f37edc61d0cfb90667a8c3

commit bcb668f7df7636cf35f37edc61d0cfb90667a8c3
Author: Jennifer Apacible <apacible@chromium.org>
Date: Wed Aug 29 00:27:00 2018

[Picture in Picture] Toggle play/pause when the user presses the space bar.

Currently, any keyboard activity for the Picture-in-Picture window does
nothing. This change allows users to toggle play/pause with the keyboard,
rather than using a mouse or gesture to interact with the window. This also
allows this interaction without using a screen reader.

Also tested with VoiceOver on MacOS active.

Bug:  878597 
Change-Id: I03fb37f32fb20371e7b2ee27ef69c4872032b997
Reviewed-on: https://chromium-review.googlesource.com/1194993
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586961}
[modify] https://crrev.com/bcb668f7df7636cf35f37edc61d0cfb90667a8c3/chrome/browser/ui/views/overlay/overlay_window_views.cc

Comment 2 by apaci...@chromium.org, Aug 29

Status: Fixed (was: Assigned)
►

Sign in to add a comment