New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878594 link

Starred by 1 user
Status: Assigned
Owner:
jdufault@chromium.org
Cc:
█ elizabethchiu@chromium.org
zalcorn@chromium.org
kaznacheev@chromium.org
r...@chromium.org
alemate@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make OOBE videos load from disk (not from data URLs).

Project Member Reported by alemate@chromium.org, Aug 28 
TODO:

1) Make OOBE videos from the file system available as like chrome://oobe/resources/oobe_welcome_loop.webm resources.


2) Make OOBE play these videos.

Here is example CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1150979

This CL has everything , but it is a bit hacky and plays only one video. You need to replace URLs for all existing <video> tags with new ones (probably that's all that needs to be done on the WebUI side).

Comment 1 by alemate@chromium.org, Aug 28

Cc: r...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/218c3921ca4a1e760533a1d8cef02e44de0670a1

commit 218c3921ca4a1e760533a1d8cef02e44de0670a1
Author: Malay Keshav <malaykeshav@chromium.org>
Date: Fri Aug 31 01:01:48 2018

Implement a URLDataSource to load videos from disk for OOBE

This patch implements a URLDataSource that loads oobe video assets from
disk based on the provided chrome URL. It also installs the same for
the oobe web ui.

Bug: 878594
Change-Id: I443144d4e5ab65d313c0e56d8b988a9cb05e6109
Component: Video source, oobe
Reviewed-on: https://chromium-review.googlesource.com/1196145
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587889}
[modify] https://crrev.com/218c3921ca4a1e760533a1d8cef02e44de0670a1/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/218c3921ca4a1e760533a1d8cef02e44de0670a1/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
[add] https://crrev.com/218c3921ca4a1e760533a1d8cef02e44de0670a1/chrome/browser/ui/webui/chromeos/video_source.cc
[add] https://crrev.com/218c3921ca4a1e760533a1d8cef02e44de0670a1/chrome/browser/ui/webui/chromeos/video_source.h

Comment 3 by malaykeshav@chromium.org, Aug 31

Status: Fixed (was: Assigned)

Comment 4 by alemate@chromium.org, Sep 11

Status: Assigned (was: Fixed)
We still need to update OOBE. See https://cs.chromium.org/chromium/src/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html

Comment 5 by ovanieva@chromium.org, Sep 14

Components: UI>Shell>OOBE

Comment 6 by malaykeshav@chromium.org, Sep 14

Cc: alemate@chromium.org
Owner: alemate@chromium.org
Assigning this to @alemate since he owns this piece of code and is familiar to the logic being used to play the video files in the WebUI.

Comment 7 by alemate@chromium.org, Sep 14 

Re #6:

  Where are videos on the device file system located?

Comment 8 by alemate@chromium.org, Oct 16

Cc: jdufault@chromium.org
Labels: -M-70 M-72
Owner: jdufault@chromium.org
Jacob, could you help finding owner for this?

Comment 9 by zalcorn@chromium.org, Nov 13

Labels: -Pri-1 Pri-2
►

Sign in to add a comment