Crash in network metrics collecting part due to bug on iOS 10.0 & 10.1
Reported by
j...@snapchat.com,
Aug 28
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36 Steps to reproduce the problem: The bug sits at Apple's side: http://www.openradar.me/28301343 and should have been fixed in iOS 10.2. While we need to gate this in Cronet metrics collecting part against problematic versions. What is the expected behavior? What went wrong? We calls metrics collecting delegate method on problematic versions: https://cs.chromium.org/chromium/src/components/cronet/ios/cronet_metrics.mm?dr=C&q=cronet_metrics&g=0&l=254 Crashed report ID: How much crashed? Just one tab Is it a problem with a plugin? N/A Did this work before? N/A Chrome version: 65.0.3325.152 Channel: stable OS Version: iOS 10.0 & 10.1 Flash Version:
,
Aug 29
,
Aug 29
Re#1 This is a crash on iOS not on Mac OS. Is chrome://crashes also for iOS? Currently we haven't upgraded to version 68.0.3440.83 due to app size issues (upgrading the version would increase the app size by 400kb).
,
Aug 29
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 30
Network bug triager here: if I understand this thread correctly, this is an issue for cronet users. And we should gate the version check to 10.2 where the iOS bug is fixed. Do we know when 10.2 will be available? Adding this to mef@'s radar.
,
Aug 30
jni@: What is suggested fix / workaround? Don't enable metrics on iOS 10.2? Could you file a bug for the binary size increase mentioned in comment 3? How blocking is it for future updates? The app must use recent version of Cronet to ensure security, stability and support of current QUIC protocol version.
,
Aug 30
mef@: My proposal would be that we guard the metrics part against iOS versions less than 10.2 I will file a bug specifically for the app size increase, but before that I would do some analysis on that to see where this increase comes from.
,
Aug 31
,
Sep 7
I will put the version gate in the implementation of setMetricsEnabled: in Cronet.mm. This way the app can call setMetricsEnabled without any gating, but it will be a no-op pre-10.2. In the meanwhile the app could gate the call to [Cronet setMetricsEnabled:YES] on @available(iOS 10.2, *). This would work without any changes to Cronet.
,
Sep 18
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0c63e57609923796f420475e0688264cd6d238b commit d0c63e57609923796f420475e0688264cd6d238b Author: Misha Efimov <mef@chromium.org> Date: Tue Sep 18 17:05:29 2018 [Cronet] Don't collect NSURLSessionTaskMetrics until iOS 10.2. - Avoid bug in iOS 10.0 and 10.1: http://www.openradar.me/28301343 Bug: 878589 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet Change-Id: Ifef1c2c6fa35023a947d53c77a9910a6726b55a6 Reviewed-on: https://chromium-review.googlesource.com/1231133 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592084} [modify] https://crrev.com/d0c63e57609923796f420475e0688264cd6d238b/components/cronet/ios/Cronet.mm [modify] https://crrev.com/d0c63e57609923796f420475e0688264cd6d238b/components/cronet/ios/test/cronet_metrics_test.mm [modify] https://crrev.com/d0c63e57609923796f420475e0688264cd6d238b/components/cronet/ios/test/cronet_quic_test.mm
,
Sep 18
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by jmukthavaram@chromium.org
, Aug 29Labels: Needs-Milestone Needs-Feedback
46.5 KB
46.5 KB View Download