New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878587 link

Starred by 1 user
Status: Duplicate
Merged: issue 881476
Owner: ----
Closed: Aug 29
Cc:
█ lawrencewu@chromium.org
gab@chromium.org
fdoray@chromium.org
asvitk...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 28 
"SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySAsSBUZsYWtlIj1TYWZlQnJvd3NpbmdQcmVmc1Rlc3QuR2V0RXh0ZW5kZWRSZXBvcnRpbmdQcmVmTmFtZV9FeGhhdXN0aXZlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by yutak@chromium.org, Aug 29 

Crash log:

[ RUN      ] SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive
[ RUN      ] SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
	std::_Tree<std::_Tset_traits<SkSL::String,std::less<SkSL::String>,std::allocator<SkSL::String>,0> >::find [0x029E303E+14]
	base::FeatureList::CheckFeatureIdentity [0x03DCC367+151]
	base::FeatureList::IsFeatureEnabled [0x03DCBC7C+572]
	base::FeatureList::IsEnabled [0x03DCBA26+22]
	base::PlatformThread::SetCurrentThreadPriority [0x03E3584A+42]
	base::PlatformThread::GetCurrentThreadPriority [0x03E35BB9+457]
	BaseThreadInitThunk [0x759A337A+18]
	RtlInitializeExceptionChain [0x772292B2+99]
	RtlInitializeExceptionChain [0x77229285+54]
[ RUN      ] SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive
[ RUN      ] SafeBrowsingPrefsTest.GetExtendedReportingPrefName_Exhaustive
[5424:748:0828/014615.917:7748538:FATAL:lock.cc(19)] Check failed: owning_thread_ref_.is_null().
Backtrace:
	base::debug::StackTrace::StackTrace [0x03DC9FC0+32]
	base::debug::StackTrace::StackTrace [0x03DC977D+13]
	logging::LogMessage::~LogMessage [0x03DE1760+96]
	base::Lock::~Lock [0x03E21E2E+78]
	base::FeatureList::~FeatureList [0x03DCAACA+58]
	base::test::ScopedFeatureList::~ScopedFeatureList [0x041B5DC8+104]
	std::unique_ptr<base::test::ScopedFeatureList,std::default_delete<base::test::ScopedFeatureList> >::reset [0x023B6CF6+22]
	safe_browsing::SafeBrowsingPrefsTest::ResetExperiments [0x023B4929+153]
	safe_browsing::SafeBrowsingPrefsTest::TestGetPrefName [0x023B4340+48]
	safe_browsing::SafeBrowsingPrefsTest_GetExtendedReportingPrefName_Exhaustive_Test::TestBody [0x023B45CF+95]
	testing::Test::Run [0x024E7D00+192]
	testing::TestInfo::Run [0x024E84B2+210]
	testing::TestCase::Run [0x024E8964+244]
	testing::internal::UnitTestImpl::RunAllTests [0x024EEB15+629]
	testing::UnitTest::Run [0x024EE799+153]
	base::TestSuite::Run [0x041BB334+100]
	base::RepeatingCallback<content::WebContents * __cdecl(void)>::Run [0x032B3FCB+43]
	base::LaunchUnitTests [0x041BCCC5+485]
	base::LaunchUnitTests [0x041BCB97+183]
	main [0x01FBCBD8+96]
	__scrt_common_main_seh [0x068CE4FC+250] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
	BaseThreadInitThunk [0x759A337A+18]
	RtlInitializeExceptionChain [0x772292B2+99]
	RtlInitializeExceptionChain [0x77229285+54]

Comment 2 by yutak@chromium.org, Aug 29 

This stack trace is really confusing and I'm not sure if this is
base::FeatureList's fault or safe browsing's fault...

Or perhaps PlatformThread::SetCurrentThreadPriority is using
base::FeatureList before it gets initialized.

Comment 3 by yutak@chromium.org, Aug 29

Cc: asvitk...@chromium.org lawrencewu@chromium.org
Inviting folks who contributed to base::FeatureList

Comment 4 by asvitk...@chromium.org, Aug 29

Cc: fdoray@chromium.org gab@chromium.org
Status: WontFix (was: Untriaged)
I think the offending CL has been reverted?

https://chromium-review.googlesource.com/c/chromium/src/+/1194035

Comment 5 by battre@chromium.org, Sep 10

Mergedinto: 881476
Status: Duplicate (was: WontFix)
Nope, still broken.
►

Sign in to add a comment