Findit has detected flake occurrences for the test PolicyPrefsTest.PolicyToPrefsMapping Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I598dd72b1c7d99df18d3b337f09bbeab0b80cdb9 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVymwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJlY2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNzExNjIvYnJvd3Nlcl90ZXN0cy9VRzlzYVdONVVISmxabk5VWlhOMExsQnZiR2xqZVZSdlVISmxabk5OWVhCd2FXNW4MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PolicyPrefsTest.PolicyToPrefsMapping&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVymwELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJlY2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNzExNjIvYnJvd3Nlcl90ZXN0cy9VRzlzYVdONVVISmxabk5VWlhOMExsQnZiR2xqZVZSdlVISmxabk5OWVhCd2FXNW4MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
Is this fixed? Can this be moved out of the sheriff queue?
Not fixed yet. CL is pending review.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd7ed286f620ab884105c5d6b94ce013edcdf43a commit fd7ed286f620ab884105c5d6b94ce013edcdf43a Author: Giovanni Ortuño Urquidi <ortuno@chromium.org> Date: Wed Aug 29 13:26:49 2018 desktop-pwas: Listen for the "profile destroyed" notification Neither Shutdown() gets called on the WebAppProvider nor has the WebAppProvider been destroyed by the time we DCHECK for leaked hosts. So the WebAppProvider never has a chance to clean up before we check that all hosts are gone. To get around this, we clean up when the "NOTIFICATION_PROFILE_DESTROYED" notification is sent, which happens right before the DCHECK. Bug: 876176 , 878586 Change-Id: I6262ddcf8ca9594bfc333feb9c3cf4ccdc7f8b5e Reviewed-on: https://chromium-review.googlesource.com/1195243 Reviewed-by: Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#587091} [modify] https://crrev.com/fd7ed286f620ab884105c5d6b94ce013edcdf43a/chrome/browser/web_applications/extensions/pending_bookmark_app_manager_browsertest.cc [modify] https://crrev.com/fd7ed286f620ab884105c5d6b94ce013edcdf43a/chrome/browser/web_applications/web_app_provider.cc [modify] https://crrev.com/fd7ed286f620ab884105c5d6b94ce013edcdf43a/chrome/browser/web_applications/web_app_provider.h
Comment 1 by ortuno@chromium.org
, Aug 29Owner: ortuno@chromium.org
Status: Started (was: Available)