In the initial implementation this method takes no arguments, but it should take some kind of options dictionary as explained in https://github.com/WICG/writable-files/blob/master/EXPLAINER.md#example-code.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9594a943f4c303203c5e5ce258adc9b3ebd10d73 commit 9594a943f4c303203c5e5ce258adc9b3ebd10d73 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Tue Sep 25 22:39:24 2018 [FileSystem] Add support for selecting multiple files or directories. Bug: 878581 Change-Id: I65fc0029da2e3951495a6cd96704085e5c1b942c Reviewed-on: https://chromium-review.googlesource.com/1227366 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#594132} [add] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/content/browser/fileapi/README.md [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/content/browser/fileapi/file_system_chooser.cc [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/content/browser/fileapi/file_system_chooser.h [add] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/content/browser/fileapi/file_system_chooser_browsertest.cc [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/content/browser/fileapi/file_system_manager_impl.cc [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/content/browser/fileapi/file_system_manager_impl.h [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/content/test/BUILD.gn [add] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/storage/browser/fileapi/README.md [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/public/mojom/filesystem/file_system.mojom [add] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/README.md [add] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/choose_file_system_entries_options.idl [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/dom_window_file_system.cc [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/dom_window_file_system.h [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/local_file_system.cc [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/local_file_system.h [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/filesystem/window_file_system.idl [modify] https://crrev.com/9594a943f4c303203c5e5ce258adc9b3ebd10d73/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b515e53ee075b35a3f0c5de6b65becf69d5951e commit 6b515e53ee075b35a3f0c5de6b65becf69d5951e Author: Adithya Srinivasan <adithyas@chromium.org> Date: Wed Sep 26 20:00:34 2018 Revert "[FileSystem] Add support for selecting multiple files or directories." This reverts commit 9594a943f4c303203c5e5ce258adc9b3ebd10d73. Reason for revert: https://crrev.com/c/1217506 is causing crashes in Canary (https://crbug.com/889422). Reverting this CL is necessary in order to be able to revert that CL. Original change's description: > [FileSystem] Add support for selecting multiple files or directories. > > Bug: 878581 > Change-Id: I65fc0029da2e3951495a6cd96704085e5c1b942c > Reviewed-on: https://chromium-review.googlesource.com/1227366 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594132} TBR=dcheng@chromium.org,dmurph@chromium.org,mek@chromium.org Change-Id: I8af7db79f5156bc354ade87b2ac5e31955b41cc3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878581 Reviewed-on: https://chromium-review.googlesource.com/1246862 Reviewed-by: Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#594446} [delete] https://crrev.com/c00db861aebca3b14ab27a41c7425bedcbd81ae4/content/browser/fileapi/README.md [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/content/browser/fileapi/file_system_chooser.cc [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/content/browser/fileapi/file_system_chooser.h [delete] https://crrev.com/c00db861aebca3b14ab27a41c7425bedcbd81ae4/content/browser/fileapi/file_system_chooser_browsertest.cc [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/content/browser/fileapi/file_system_manager_impl.cc [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/content/browser/fileapi/file_system_manager_impl.h [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/content/test/BUILD.gn [delete] https://crrev.com/c00db861aebca3b14ab27a41c7425bedcbd81ae4/storage/browser/fileapi/README.md [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/public/mojom/filesystem/file_system.mojom [delete] https://crrev.com/c00db861aebca3b14ab27a41c7425bedcbd81ae4/third_party/blink/renderer/modules/filesystem/README.md [delete] https://crrev.com/c00db861aebca3b14ab27a41c7425bedcbd81ae4/third_party/blink/renderer/modules/filesystem/choose_file_system_entries_options.idl [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/filesystem/dom_window_file_system.cc [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/filesystem/dom_window_file_system.h [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/filesystem/local_file_system.cc [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/filesystem/local_file_system.h [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/filesystem/window_file_system.idl [modify] https://crrev.com/6b515e53ee075b35a3f0c5de6b65becf69d5951e/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd47fd6d707c73fa8709cb6330057ad58894775b commit dd47fd6d707c73fa8709cb6330057ad58894775b Author: Marijn Kruisselbrink <mek@chromium.org> Date: Fri Oct 05 19:17:20 2018 Reland "[FileSystem] Add support for selecting multiple files or directories." This is a reland of 9594a943f4c303203c5e5ce258adc9b3ebd10d73 Original change's description: > [FileSystem] Add support for selecting multiple files or directories. > > Bug: 878581 > Change-Id: I65fc0029da2e3951495a6cd96704085e5c1b942c > Reviewed-on: https://chromium-review.googlesource.com/1227366 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniel Murphy <dmurph@chromium.org> > Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#594132} Tbr: dmurph@chromium.org, dcheng@chromium.org Bug: 878581 Change-Id: Ic145a6b48279f29368fbbc802751eb3d43b4ef4c Reviewed-on: https://chromium-review.googlesource.com/c/1265058 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#597233} [add] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/content/browser/fileapi/README.md [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/content/browser/fileapi/file_system_chooser.cc [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/content/browser/fileapi/file_system_chooser.h [add] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/content/browser/fileapi/file_system_chooser_browsertest.cc [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/content/browser/fileapi/file_system_manager_impl.cc [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/content/browser/fileapi/file_system_manager_impl.h [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/content/test/BUILD.gn [add] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/storage/browser/fileapi/README.md [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/public/mojom/filesystem/file_system.mojom [add] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/README.md [add] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/choose_file_system_entries_options.idl [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/dom_window_file_system.cc [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/dom_window_file_system.h [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/local_file_system.cc [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/local_file_system.h [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/filesystem/window_file_system.idl [modify] https://crrev.com/dd47fd6d707c73fa8709cb6330057ad58894775b/third_party/blink/renderer/modules/modules_idl_files.gni
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d9da613a2f38a7267e8a8de742a2745fbda6bf34 commit d9da613a2f38a7267e8a8de742a2745fbda6bf34 Author: Marijn Kruisselbrink <mek@chromium.org> Date: Tue Oct 09 20:32:27 2018 [FileSystem] Allow specifying accepted mime types/extensions in chooser. Bug: 878581 Change-Id: Id2a7f4e2aeb5a2bf256dbbd202f41828da14f331 Reviewed-on: https://chromium-review.googlesource.com/c/1237373 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#598066} [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_chooser.cc [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_chooser.h [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_chooser_browsertest.cc [add] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_chooser_test_helpers.cc [add] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_chooser_test_helpers.h [add] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_chooser_unittest.cc [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_manager_impl.cc [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/browser/fileapi/file_system_manager_impl.h [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/content/test/BUILD.gn [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/third_party/blink/public/mojom/filesystem/file_system.mojom [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/third_party/blink/renderer/modules/filesystem/choose_file_system_entries_options.idl [add] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/third_party/blink/renderer/modules/filesystem/choose_file_system_entries_options_accepts.idl [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.cc [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/third_party/blink/renderer/modules/filesystem/file_system_dispatcher.h [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/third_party/blink/renderer/modules/filesystem/local_file_system.cc [modify] https://crrev.com/d9da613a2f38a7267e8a8de742a2745fbda6bf34/third_party/blink/renderer/modules/modules_idl_files.gni
Comment 1 by bugdroid1@chromium.org
, Sep 25