New issue
Advanced search Search tips

Issue 878546 link

Starred by 1 user
Status: Fixed
Owner:
mdjones@chromium.org
Closed: Sep 6
Cc:
amaralp@chromium.org
lzbylut@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Team-Accessibility

Blocking:
issue 875875



Sign in to add a comment

[Accessibility][Duet] Top to bottom focus is not ideal

Project Member Reported by mdjones@chromium.org, Aug 28 
1. Enable talkback
2. tap to bring focus to the omnibox
3. Swipe right to select the next UI control
4. Repeat #3 several times

Instead of focusing the buttons in the bottom toolbar, the web content is focused instead. We should change this so that the bottom toolbar is focused before the web content is.

This can probably be handled by specifying XML attributes in the layout xml.

Comment 1 by amaralp@chromium.org, Aug 29 

Swiping from right to left will take the user to the bottom toolbar. The first swipe was omnibox -> security lock icon. The second one was lock icon -> bottom overflow menu. The next was overflow menu -> tab switcher. Maybe this is reasonable? I think we should get input from accessibility folks before implementing something different. mdjones@, are you already in contact with someone from accessibility?

Comment 2 by dtapu...@chromium.org, Aug 29

Components: UI>Browser>Omnibox UI>Accessibility

Comment 3 by mdjones@chromium.org, Aug 31

Blocking: 875875

Comment 4 by mdjones@chromium.org, Sep 4

Cc: -mdjones@chromium.org
Owner: mdjones@chromium.org
Status: Started (was: Available)

Comment 5 by mdjones@chromium.org, Sep 5

Labels: M-70 Merge-Request-70
Fix landed here: https://chromium.googlesource.com/chromium/src/+/41f65e77d5e09d3a093d3f05079bc57ac20314aa

Requesting merge into M70 as this would block a stable experiment.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41f65e77d5e09d3a093d3f05079bc57ac20314aa

commit 41f65e77d5e09d3a093d3f05079bc57ac20314aa
Author: Matthew Jones <mdjones@chromium.org>
Date: Tue Sep 04 21:42:25 2018

Focus bottom toolbar after top in talkback

This patch conditionally adds the bottom toolbar as the next focus
target after the top toolbar when Duet is enabled.

Bug:  878546 
Change-Id: If9281c8354d340fd5df96fb3aa5c9200b4783a58
Reviewed-on: https://chromium-review.googlesource.com/1204712
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588649}
[modify] https://crrev.com/41f65e77d5e09d3a093d3f05079bc57ac20314aa/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 6

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 6

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cabf66950d13b8108c11f44f52f4076eafd3bdc

commit 6cabf66950d13b8108c11f44f52f4076eafd3bdc
Author: Matthew Jones <mdjones@chromium.org>
Date: Thu Sep 06 18:21:34 2018

Focus bottom toolbar after top in talkback

This patch conditionally adds the bottom toolbar as the next focus
target after the top toolbar when Duet is enabled.

TBR=mdjones@chromium.org

(cherry picked from commit 41f65e77d5e09d3a093d3f05079bc57ac20314aa)

Bug:  878546 
Change-Id: If9281c8354d340fd5df96fb3aa5c9200b4783a58
Reviewed-on: https://chromium-review.googlesource.com/1204712
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588649}
Reviewed-on: https://chromium-review.googlesource.com/1211283
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#92}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/6cabf66950d13b8108c11f44f52f4076eafd3bdc/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java

Comment 9 by mdjones@chromium.org, Sep 6

Status: Fixed (was: Started)
►

Sign in to add a comment