New issue
Advanced search Search tips

Issue 878540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 754101
issue 869238


Participants' hotlists:
Harmony-Cast-Dialog


Sign in to add a comment

Add an item to Cast toolbar icon context menu for enabling media remoting

Project Member Reported by taku...@chromium.org, Aug 28

Issue description

Per the mocks, there should be an item to toggle the preference for enabling/disabling media remoting.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ebdc8f4f86554492a1a368db16a01e1d9174b45

commit 9ebdc8f4f86554492a1a368db16a01e1d9174b45
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Fri Aug 31 15:50:50 2018

Add an item to media router context menu for media remoting

Add an item labelled "Optimize fullscreen videos" to the context menu
of the Cast toolbar icon behind the ViewsCastDialog flag. Toggling
this enables/disables media remoting.

Bug:  878540 
Change-Id: Ic1003d6ee9e38bd87d9807aa69e5ef5d23e9b637
Reviewed-on: https://chromium-review.googlesource.com/1194972
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588036}
[modify] https://crrev.com/9ebdc8f4f86554492a1a368db16a01e1d9174b45/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/9ebdc8f4f86554492a1a368db16a01e1d9174b45/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/9ebdc8f4f86554492a1a368db16a01e1d9174b45/chrome/browser/ui/toolbar/media_router_contextual_menu.cc
[modify] https://crrev.com/9ebdc8f4f86554492a1a368db16a01e1d9174b45/chrome/browser/ui/toolbar/media_router_contextual_menu.h
[modify] https://crrev.com/9ebdc8f4f86554492a1a368db16a01e1d9174b45/chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc

Status: Fixed (was: Assigned)
Blocking: 869238

Sign in to add a comment