Kiosk app does not auto-launch |
||||
Issue descriptionTracking bug for b/109661295.
,
Aug 29
Presume this doesn't effect 69 since that is still using the WebUI login?
,
Aug 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e8cdebbb7daf88ce03aa7984426bea4daf86a98 commit 4e8cdebbb7daf88ce03aa7984426bea4daf86a98 Author: Quan Nguyen <qnnguyen@chromium.org> Date: Wed Aug 29 01:10:27 2018 cros: When kiosk apps are loaded, clear out old outstanding app launch errors. This allows the auto-launched kiosk apps to run on next reboot after being user-canceled during the splash screen. Bug: 878537 Change-Id: I023a074a908ac4e8b3d32189cc9c09ad145aeec9 Reviewed-on: https://chromium-review.googlesource.com/1195042 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#586978} [modify] https://crrev.com/4e8cdebbb7daf88ce03aa7984426bea4daf86a98/chrome/browser/chromeos/login/ui/kiosk_app_menu_updater.cc
,
Aug 29
No effect on 69 I think, since the error gets cleared on webui login. The CL I submitted yesterday should do the same for views.
,
Aug 29
While the issue of not clearing KioskAppLaunchError is resolved, the error itself is not shown in the current login UI. It should be triggered by the following code: https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc?l=190&rcl=c2e430c4a5ef55038aac8df4f3e4537c55e65f0a
,
Aug 29
That's correct, the error bubble code hasn't been implemented in the login rewrite yet. It'll require some new code. Do we have a mockup or reference somewhere with the look + dimensions of the error bubble?
,
Aug 29
We should just copy what we have on the WebUI login? In either case, we should file a separate bug for that.
,
Aug 30
So, are we comfortable not having tests for this case? Sergey/Quan, is it feasible to add a test to avoid future regressions?
,
Aug 30
Filed https://crbug.com/879122 At least it's blocked by yet not-implemented UI.
,
Aug 30
Issue 875036 has been merged into this issue.
,
Oct 23
issue is still present in M69 10895.86.0 69.0.3497.128. The first launch after enrollment succeeds but when the device is rebooted or turned off arc ++ applications fail to launch
,
Oct 23
AFAIU, the issue unfortunately exists in M69 and won't be fixed there as M70 almost hit stable branch. In M70 it should be fixed with CL from #3. |
||||
►
Sign in to add a comment |
||||
Comment 1 by qnnguyen@chromium.org
, Aug 28