New issue
Advanced search Search tips

Issue 878535 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

"media/avtrack/video-track-selected.html" is flaky with FFmpeg dcheck on read_cb_

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 28

Issue description

"media/avtrack/video-track-selected.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidtZWRpYS9hdnRyYWNrL3ZpZGVvLXRyYWNrLXNlbGVjdGVkLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: -Tests>Flaky Internals>Media
Summary: "media/avtrack/video-track-selected.html" is flaky with FFmpeg dcheck on read_cb_ (was: "media/avtrack/video-track-selected.html" is flaky)
It appears that there is FFmpeg related stack trace for this test consistently with every failure.

crash log for renderer (pid <unknown>):
STDOUT: <empty>
STDERR: [71985:775:0828/133747.342652:ERROR:audio_manager_mac.cc(235)] Error getting default AudioDevice.
STDERR: [71985:775:0828/133747.343113:ERROR:audio_manager_mac.cc(820)] Invalid output device 
STDERR: [71985:775:0828/133747.343730:ERROR:audio_manager_mac.cc(721)] Failed to open output device: 
STDERR: [71985:775:0828/133747.343967:ERROR:audio_output_resampler.cc(385)] Unable to open audio device in high latency mode.  Falling back to fake audio output.
STDERR: [71987:78919:0828/133747.345229:FATAL:ffmpeg_demuxer.cc(674)] Check failed: read_cb_.is_null(). There should be no pending read
STDERR: 0   libbase.dylib                       0x00000001140d3c5e base::debug::StackTrace::StackTrace(unsigned long) + 174
STDERR: 1   libbase.dylib                       0x00000001140d3d1d base::debug::StackTrace::StackTrace(unsigned long) + 29
STDERR: 2   libbase.dylib                       0x0000000113cb16ac base::debug::StackTrace::StackTrace() + 28
STDERR: 3   libbase.dylib                       0x0000000113d2d32c logging::LogMessage::~LogMessage() + 460
STDERR: 4   libbase.dylib                       0x0000000113d2af25 logging::LogMessage::~LogMessage() + 21
STDERR: 5   libmedia.dylib                      0x00000001287d40cb media::FFmpegDemuxerStream::FlushBuffers(bool) + 379
STDERR: 6   libmedia.dylib                      0x00000001287e4925 media::FFmpegDemuxer::OnVideoSeekedForTrackChange(media::DemuxerStream*, base::OnceCallback<void ()>) + 37
STDERR: 7   libmedia.dylib                      0x00000001287f7b43 void base::internal::FunctorTraits<void (media::FFmpegDemuxer::*)(media::DemuxerStream*, base::OnceCallback<void ()>), void>::Invoke<void (media::FFmpegDemuxer::*)(media::DemuxerStream*, base::OnceCallback<void ()>), base::WeakPtr<media::FFmpegDemuxer>, media::DemuxerStream*, base::OnceCallback<void ()> >(void (media::FFmpegDemuxer::*)(media::DemuxerStream*, base::OnceCallback<void ()>), base::WeakPtr<media::FFmpegDemuxer>&&, media::DemuxerStream*&&, base::OnceCallback<void ()>&&) + 211
STDERR: 8   libmedia.dylib                      0x00000001287f7a35 void base::internal::InvokeHelper<true, void>::MakeItSo<void (media::FFmpegDemuxer::*)(media::DemuxerStream*, base::OnceCallback<void ()>), base::WeakPtr<media::FFmpegDemuxer>, media::DemuxerStream*, base::OnceCallback<void ()> >(void (media::FFmpegDemuxer::*&&)(media::DemuxerStream*, base::OnceCallback<void ()>), base::WeakPtr<media::FFmpegDemuxer>&&, media::DemuxerStream*&&, base::OnceCallback<void ()>&&) + 133
STDERR: 9   libmedia.dylib                      0x00000001287f799d void base::internal::Invoker<base::internal::BindState<void (media::FFmpegDemuxer::*)(media::DemuxerStream*, base::OnceCallback<void ()>), base::WeakPtr<media::FFmpegDemuxer>, media::DemuxerStream*, base::OnceCallback<void ()> >, void ()>::RunImpl<void (media::FFmpegDemuxer::*)(media::DemuxerStream*, base::OnceCallback<void ()>), std::__1::tuple<base::WeakPtr<media::FFmpegDemuxer>, media::DemuxerStream*, base::OnceCallback<void ()> >, 0ul, 1ul, 2ul>(void (media::FFmpegDemuxer::*&&)(media::DemuxerStream*, base::OnceCallback<void ()>), std::__1::tuple<base::WeakPtr<media::FFmpegDemuxer>, media::DemuxerStream*, base::OnceCallback<void ()> >&&, std::__1::integer_sequence<unsigned long, 0ul, 1ul, 2ul>) + 173
STDERR: 10  libmedia.dylib                      0x00000001287f7859 base::internal::Invoker<base::internal::BindState<void (media::FFmpegDemuxer::*)(media::DemuxerStream*, base::OnceCallback<void ()>), base::WeakPtr<media::FFmpegDemuxer>, media::DemuxerStream*, base::OnceCallback<void ()> >, void ()>::RunOnce(base::internal::BindStateBase*) + 57
STDERR: 11  libbase.dylib                       0x0000000113c5707c base::OnceCallback<void ()>::Run() && + 92
STDERR: 12  libbase.dylib                       0x0000000113fbd1b5 base::(anonymous namespace)::PostTaskAndReplyRelay::RunReply(base::(anonymous namespace)::PostTaskAndReplyRelay) + 357
STDERR: 13  libbase.dylib                       0x0000000113fbdc50 void base::internal::FunctorTraits<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), void>::Invoke<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay>(void (*&&)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay&&) + 80
STDERR: 14  libbase.dylib                       0x0000000113fbdbbd void base::internal::InvokeHelper<false, void>::MakeItSo<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay>(void (*&&)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay&&) + 45
STDERR: 15  libbase.dylib                       0x0000000113fbdb80 void base::internal::Invoker<base::internal::BindState<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay>, void ()>::RunImpl<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), std::__1::tuple<base::(anonymous namespace)::PostTaskAndReplyRelay>, 0ul>(void (*&&)(base::(anonymous namespace)::PostTaskAndReplyRelay), std::__1::tuple<base::(anonymous namespace)::PostTaskAndReplyRelay>&&, std::__1::integer_sequence<unsigned long, 0ul>) + 80
STDERR: 16  libbase.dylib                       0x0000000113fbdac9 base::internal::Invoker<base::internal::BindState<void (*)(base::(anonymous namespace)::PostTaskAndReplyRelay), base::(anonymous namespace)::PostTaskAndReplyRelay>, void ()>::RunOnce(base::internal::BindStateBase*) + 57
STDERR: 17  libbase.dylib                       0x0000000113c5707c base::OnceCallback<void ()>::Run() && + 92
STDERR: 18  libbase.dylib                       0x0000000113cb3269 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 1033
STDERR: 19  libbase.dylib                       0x0000000113d7fc4f base::MessageLoop::RunTask(base::PendingTask*) + 1199
STDERR: 20  libbase.dylib                       0x0000000113d8014f base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) + 95
STDERR: 21  libbase.dylib                       0x0000000113d807aa base::MessageLoop::DoWork() + 490
STDERR: 22  libbase.dylib                       0x0000000113d8ccce base::MessagePumpDefault::Run(base::MessagePump::Delegate*) + 78
STDERR: 23  libbase.dylib                       0x0000000113d7f2cc base::MessageLoop::Run(bool) + 556
STDERR: 24  libbase.dylib                       0x0000000113e6a6de base::RunLoop::Run() + 606
STDERR: 25  libbase.dylib                       0x0000000113fcc109 base::Thread::Run(base::RunLoop*) + 393
STDERR: 26  libbase.dylib                       0x0000000113fcceb7 base::Thread::ThreadMain() + 2631
STDERR: 27  libbase.dylib                       0x00000001141056da base::(anonymous namespace)::ThreadFunc(void*) + 682
STDERR: 28  libsystem_pthread.dylib             0x00007fff5366e661 _pthread_body + 340
STDERR: 29  libsystem_pthread.dylib             0x00007fff5366e50d _pthread_body + 0
STDERR: 30  libsystem_pthread.dylib             0x00007fff5366dbf9 thread_start + 13
STDERR: 
Owner: tmathmeyer@chromium.org
Status: Assigned (was: Untriaged)
In the mean time I'm updating the test expectation.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a71de68299cb15af0346c3da27322c27788d248c

commit a71de68299cb15af0346c3da27322c27788d248c
Author: Yuta Kitamura <yutak@chromium.org>
Date: Wed Aug 29 09:19:54 2018

video-track-selected.html is flaky.

This test sometimes crashes on all platforms.

TBR=nednguyen@chromium.org,tmathmeyer@chromium.org

Bug:  878535 
Change-Id: I0c8a04432bc04ab2e96179e8f4fd60cf255bcf26
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1195126
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587048}
[modify] https://crrev.com/a71de68299cb15af0346c3da27322c27788d248c/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Pri-1 -Sheriff-Chromium Pri-2
Test expectation updated + has an owner => out of sheriff queue.
Ahh crap. apparently the bots flaked yesterday after I submitted, and it was never merged: https://chromium-review.googlesource.com/c/chromium/src/+/1194963

I'll roll back the test exclusion after this lands
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/707c0aa45d30296165cef33d69754220b210af8c

commit 707c0aa45d30296165cef33d69754220b210af8c
Author: Ted Meyer <tmathmeyer@chromium.org>
Date: Wed Aug 29 17:36:48 2018

Don't worry about pending reads for a track-change-seek

Bug:  878535 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib533d391f818054defe9284804e230edfbffdfb3
Reviewed-on: https://chromium-review.googlesource.com/1194963
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587181}
[modify] https://crrev.com/707c0aa45d30296165cef33d69754220b210af8c/media/filters/ffmpeg_demuxer.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d73e3f447ce7daa9d060724afa535076c8c1a729

commit d73e3f447ce7daa9d060724afa535076c8c1a729
Author: Ted Meyer <tmathmeyer@chromium.org>
Date: Thu Aug 30 01:46:58 2018

re-enable test, as it is no longer flaky

Bug:  878535 
Change-Id: I7f8acff01d1dc71f9b2fb409b93e22a418f8b5ea
Reviewed-on: https://chromium-review.googlesource.com/1196004
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587406}
[modify] https://crrev.com/d73e3f447ce7daa9d060724afa535076c8c1a729/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment