Extra divider in Save as window |
||||
Issue descriptionChrome OS version: 70.0.3532.0 Steps to reproduce: 1. Click to save a file from the browser. 2. Notice the Save as window Expected result: The left hand navigation starts with My files Observed result: An extra divider is shown before My files
,
Sep 27
Yeap, can reproduce in ToT (m71), checking.
,
Sep 27
,
Sep 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65d577fb9759e31673e19d76db8b4a4e447dab39 commit 65d577fb9759e31673e19d76db8b4a4e447dab39 Author: Luciano Pacheco <lucmult@chromium.org> Date: Thu Sep 27 05:56:23 2018 Fix extra divider line in save as dialog Change directory tree to the first item's section instead of static TOP section to determine if the first section divider should appear. Change the value of section-start attribute to be the current section which is the correct value, instead of previous section. While here modernized this function to use const/let instead of var. Bug: 878531 Test: browsertest --gtest_filter='FileManagerJsTest.DirectoryTree*' Change-Id: If8db170594608fef04913f3f6fe8235764eb03f7 Reviewed-on: https://chromium-review.googlesource.com/1248066 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#594604} [modify] https://crrev.com/65d577fb9759e31673e19d76db8b4a4e447dab39/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js [modify] https://crrev.com/65d577fb9759e31673e19d76db8b4a4e447dab39/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.html [modify] https://crrev.com/65d577fb9759e31673e19d76db8b4a4e447dab39/ui/file_manager/file_manager/foreground/js/ui/directory_tree_unittest.js
,
Oct 1
|
||||
►
Sign in to add a comment |
||||
Comment 1 by slangley@chromium.org
, Aug 28Status: Assigned (was: Available)