New issue
Advanced search Search tips

Issue 878525 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Permission API: Support "persistent-storage" permission

Project Member Reported by jsb...@chromium.org, Aug 28

Issue description

Both the Permission API https://w3c.github.io/permissions/ and Storage API https://storage.spec.whatwg.org/ define "persistent-storage" as one of the permission types usable with navigator.permissions.query(), corresponding to the permission granted by navigator.storage.persist() and inspected by navigator.storage.persisted()

Firefox ships this, but it's missing in Chrome.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e5d5b7ac865085906a106d1408e101ceefedea6

commit 9e5d5b7ac865085906a106d1408e101ceefedea6
Author: Joshua Bell <jsbell@chromium.org>
Date: Thu Aug 30 23:26:41 2018

Storage API: Register "persistent-storage" permission string

The Storage API [1] defines the "persistent-storage" string to allow
querying the state of the permission. Plug this into the Permission
API [2] implementation and add a web platform test.

[1] https://storage.spec.whatwg.org/
[2] https://w3c.github.io/permissions

Intent to Ship: https://groups.google.com/a/chromium.org/d/topic/blink-dev/FRAmGlAoDTY/discussion
ChromeStatus: https://www.chromestatus.com/feature/4770049554382848

Bug:  878525 

Change-Id: Ia12fb43676e04e7e60ad58b5ffbd7ee22f78ffc4
Reviewed-on: https://chromium-review.googlesource.com/1194106
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587839}
[modify] https://crrev.com/9e5d5b7ac865085906a106d1408e101ceefedea6/chrome/browser/storage/durable_storage_browsertest.cc
[modify] https://crrev.com/9e5d5b7ac865085906a106d1408e101ceefedea6/chrome/test/data/durable/durability-permissions.html
[add] https://crrev.com/9e5d5b7ac865085906a106d1408e101ceefedea6/third_party/WebKit/LayoutTests/external/wpt/storage/permission-query.https.any.js
[modify] https://crrev.com/9e5d5b7ac865085906a106d1408e101ceefedea6/third_party/blink/renderer/modules/permissions/permission_descriptor.idl
[modify] https://crrev.com/9e5d5b7ac865085906a106d1408e101ceefedea6/third_party/blink/renderer/modules/permissions/permissions.cc

Components: Blink>PermissionsAPI
Status: Fixed (was: Started)
Looks like this just missed the cut-off for 70, so will be in 71.

Sign in to add a comment