New issue
Advanced search Search tips

Issue 878524 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Web Push trigger in the Service Worker tab inside application window is not working

Reported by aditya.p...@gmail.com, Aug 28

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce the problem:
1. Go to https://gauntface.github.io/simple-push-demo/
2. Allow Push Notifications
3. Open devtools, go to applications tab, service workers.
4. Trigger Push from Devtools

What is the expected behavior?
It should console.log `Received push` 

What went wrong?
Devtools Push trigger is not working

Did this work before? Yes 

Chrome version: 68.0.3440.106  Channel: stable
OS Version: OS X 10.13.6
Flash Version:
 
Labels: Needs-Triage-M68 Needs-Bisect
Cc: vamshi.kommuri@chromium.org
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET Target-69 Target-70 M-70 FoundIn-70 RegressedIn-66 Target-68 FoundIn-68 FoundIn-69 OS-Linux OS-Windows Pri-1
Owner: caseq@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for filing the issue!

Able to reproduce the issue on reported chrome version 68.0.3440.106 and on the latest canary 70.0.3535.0 using Mac 10.13.1, Ubuntu 17.01 and Windows 10.

Bisect Information:
--------------------
Good Build: 66.0.3329.0
Bad Build:  66.0.3330.0

You are probably looking for a change made after 531156 (known good), but no later than 531157 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/488e9ef26e7e265f627b3db349ad4440b4575e93..3c8e4852477d5b1e2da877808c998dc57db9460f
Suspecting: https://chromium.googlesource.com/chromium/src/+/3c8e4852477d5b1e2da877808c998dc57db9460f
Review URL: https://chromium-review.googlesource.com/876657

@Andrey Kosyakov: Please help us in assigning it to the right owner if this is not related to your change.
Labels: -Target-69
As this is regressed in M66 and exists on current M68 stable, this won't be a blocker for M69. Pls target fix for M70.
Friendly ping to get an update on this issue as it is marked RBS.
Thanks..!
Gentle ping! Could you please provide any update on this issue as it has been marked as a stable blocker.

Thank You!
[bulk edit] - This issue is marked as a stable blocker for M70. We are two weeks away from M70 Stable. Please take a look urgently!
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07911797fdd4aed3af960bd4b9cf019c2ea79c8e

commit 07911797fdd4aed3af960bd4b9cf019c2ea79c8e
Author: Andrey Kosyakov <caseq@chromium.org>
Date: Tue Oct 02 00:08:56 2018

DevTools: fix ServiceWorker.deliverPushMessage

Originally regressed by
https://chromium-review.googlesource.com/c/chromium/src/+/876657

Bug:  878524 
Change-Id: I3526eea2063a795b6f9049008cc564ca65c1ba04
Reviewed-on: https://chromium-review.googlesource.com/1255606
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595653}
[modify] https://crrev.com/07911797fdd4aed3af960bd4b9cf019c2ea79c8e/content/browser/devtools/protocol/service_worker_handler.cc
[add] https://crrev.com/07911797fdd4aed3af960bd4b9cf019c2ea79c8e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/service-worker/deliver-push-message-expected.txt
[add] https://crrev.com/07911797fdd4aed3af960bd4b9cf019c2ea79c8e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/service-worker/deliver-push-message.js
[add] https://crrev.com/07911797fdd4aed3af960bd4b9cf019c2ea79c8e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/service-worker/resources/push-message-service-worker.html
[add] https://crrev.com/07911797fdd4aed3af960bd4b9cf019c2ea79c8e/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/service-worker/resources/push-message-service-worker.js

Labels: Merge-Request-70
Status: Fixed (was: Assigned)
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 2

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Stable
Since this has regressed since M66, we shouldn't consider this a release blocker. Let's target M71 for this fix. 
Labels: -Merge-Review-70 Merge-Rejected-70

Sign in to add a comment