New issue
Advanced search Search tips

Issue 878509 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

41.4% regression in sizes at 586729:586732

Project Member Reported by mef@chromium.org, Aug 28

Issue description

So far the regression is reported only with DEBUG builds of Cronet for Android, so it may be ok.

The only seemingly applicable CL in the range is https://chromium-review.googlesource.com/c/chromium/src/+/1185854
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=878509

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0888f0b8ab33d0dcd19c2a0afd1735eb6a35800add06ab450a5259e3b4b14f7c


Bot(s) for this bug's original alert(s):

android_cronet_arm64_builder_dbg
Cc: chengx@chromium.org
Components: Internals>Network>Library
Labels: OS-Android
Cc: wittman@chromium.org
Owner: wittman@chromium.org
Status: Started (was: Untriaged)
Looks like this is from pulling in a new dep on //components:metrics in child processes. We'll need to avoid this, likely to introducing an abstraction layer so CallStackProfileBuilder doesn't directly depend on CallStackProfileMetricsProvider.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd3a73980b82eea000403c2c9c1f204f6612e7cf

commit fd3a73980b82eea000403c2c9c1f204f6612e7cf
Author: Mike Wittman <wittman@chromium.org>
Date: Thu Aug 30 20:10:54 2018

Rationalize call stacks targets in //components/metrics/BUILD.gn

Renames targets to better reflect what they provide. Removes the
:metrics dep from the target for child processes to avoid including
unnecessary browser-process-only code in those processes. Breaks the
direct dependency of CallStackProfileBuilder on :metrics by introducing
a receiver callback abstraction.

Bug:  878509 
Change-Id: I03a590f31be8c9641c9f375d8dbc0f8bc254b7d4
Reviewed-on: https://chromium-review.googlesource.com/1195808
Commit-Queue: Mike Wittman <wittman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587726}
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/chrome/browser/BUILD.gn
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/chrome/common/BUILD.gn
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/chrome/common/thread_profiler.cc
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/chrome/common/thread_profiler.h
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/chrome/gpu/BUILD.gn
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/components/metrics/BUILD.gn
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/components/metrics/call_stack_profile_builder.cc
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/components/metrics/call_stack_profile_builder.h
[modify] https://crrev.com/fd3a73980b82eea000403c2c9c1f204f6612e7cf/components/startup_metric_utils/browser/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/903df57a45b5d451b90be1183cbc8198dfd9c688

commit 903df57a45b5d451b90be1183cbc8198dfd9c688
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Fri Aug 31 09:59:14 2018

Revert "Rationalize call stacks targets in //components/metrics/BUILD.gn"

This reverts commit fd3a73980b82eea000403c2c9c1f204f6612e7cf.

Reason for revert: Likely culprit of  https://crbug.com/879513 .

Original change's description:
> Rationalize call stacks targets in //components/metrics/BUILD.gn
> 
> Renames targets to better reflect what they provide. Removes the
> :metrics dep from the target for child processes to avoid including
> unnecessary browser-process-only code in those processes. Breaks the
> direct dependency of CallStackProfileBuilder on :metrics by introducing
> a receiver callback abstraction.
> 
> Bug:  878509 
> Change-Id: I03a590f31be8c9641c9f375d8dbc0f8bc254b7d4
> Reviewed-on: https://chromium-review.googlesource.com/1195808
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#587726}

TBR=sky@chromium.org,wittman@chromium.org,isherman@chromium.org

Change-Id: I1ce64c7544b045a513980ff6deb6ddc804dee33f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  878509 
Reviewed-on: https://chromium-review.googlesource.com/1199083
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587978}
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/chrome/browser/BUILD.gn
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/chrome/common/BUILD.gn
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/chrome/common/thread_profiler.cc
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/chrome/common/thread_profiler.h
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/chrome/gpu/BUILD.gn
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/components/metrics/BUILD.gn
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/components/metrics/call_stack_profile_builder.cc
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/components/metrics/call_stack_profile_builder.h
[modify] https://crrev.com/903df57a45b5d451b90be1183cbc8198dfd9c688/components/startup_metric_utils/browser/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2943c9c7082865f62153731e4d34414a286e6f4b

commit 2943c9c7082865f62153731e4d34414a286e6f4b
Author: Mike Wittman <wittman@chromium.org>
Date: Fri Aug 31 19:28:57 2018

Reland "Rationalize call stacks targets in //components/metrics/BUILD.gn"

Relanding with fix for ChromeContentRendererClientMetricsTest.

Renames targets to better reflect what they provide. Removes the
:metrics dep from the target for child processes to avoid including
unnecessary browser-process-only code in those processes. Breaks the
direct dependency of CallStackProfileBuilder on :metrics by introducing
a receiver callback abstraction.

TBR=sky

Bug:  878509 ,  879513 ,  804942 
Change-Id: Ib83ad55a31b98022531a8dad740c7d5516db8caf
Reviewed-on: https://chromium-review.googlesource.com/1199764
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588114}
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/browser/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/common/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/common/thread_profiler.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/common/thread_profiler.h
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/gpu/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/chrome/renderer/chrome_content_renderer_client_unittest.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/metrics/BUILD.gn
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/metrics/call_stack_profile_builder.cc
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/metrics/call_stack_profile_builder.h
[modify] https://crrev.com/2943c9c7082865f62153731e4d34414a286e6f4b/components/startup_metric_utils/browser/BUILD.gn

Status: Fixed (was: Started)

Sign in to add a comment