New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 878506 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

git cl format does not work out-of-box

Project Member Reported by iby@chromium.org, Aug 28

Issue description

Per https://chromium.googlesource.com/chromium/src/+/master/docs/clang_format.md, "git cl format" should work with no configuration.

However, when I attempt to run it, I get 

Command "git config rietveld.server" failed.
Could not find settings file. You must configure your review setup by running "git cl config".

and running "git cl config" asking for a number of URLs (Rietveld server, ViewVC URL,  Tree status URL) which I, as a newcomer to ChromeOS, don't understand. 

There's no troubleshooting section in https://chromium.googlesource.com/chromium/src/+/master/docs/clang_format.md, so I'm not sure where to go next. Having a troubleshooting section would be very useful.

 
Is that in the chromium repo? How did you create your checkout?
I was in chromiumos/src/platform2/vm_tools/garcon  

It had been created by 'repo init' and a 'repo sync'


Labels: -OS-Linux OS-Chrome
Owner: ----
We don't know anything about chromiumos or repo. Someone in chromiumos land will need to look at this.
Components: Tools>ChromeOS-Toolchain
Components: -Tools>ChromeOS-Toolchain Infra>Client>ChromeOS>Build
This is more suited to build team than toolchain.
Cc: vapier@chromium.org
Components: -Infra>Client>ChromeOS>Build Infra>SDK
`git cl` is a Chromium tool in depot_tools meant to run on Chromium checkouts only.  it isn't a Chromium OS tool.  whether Chromium peeps want to make it work in Chromium OS repo checkouts is up to them.  CrOS build team doesn't have interest in doing so.

basically, if you want to work on CrOS, don't use `git cl`.
Can the document please say that? 

https://chromium.googlesource.com/chromiumos/docs/+/master/development_basics.md says we should use the Chromium C++ style guide (https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md), and the Chromium C++ style guide links directly to https://chromium.googlesource.com/chromium/src/+/master/docs/clang_format.md.

So there's a Chromium OS doc incorporating this by reference without any hints that it doesn't apply.

Components: -Infra>SDK
Owner: iby@chromium.org
Status: Assigned (was: Untriaged)
iby@ since you work on ChromeOS seems relevant that you should add a note and update the chromeos documentation readme so others don't fall into this problem you've identified.
Owner: lhchavez@chromium.org
lhchavez@, what's the correct equivalent for Chrome OS? 

There is none :( we only have the preupload check in https://chromium.googlesource.com/chromiumos/repohooks . but i think we should have an equivalent.
Components: Infra
Alright, it sounds like the next action items might be:
 1. Update some documentation?
 2. File a separate feature request for desired feature for Chrome OS tooling and close this bug.

Does that sound right?
i'm looking into this space, so opened issue 888623 for `cros format` support
Components: -Infra Infra>Client>ChromeOS>Build
Excellent, thanks.
Owner: vapier@chromium.org
Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment