Add support for policy configured shares |
||||||||||
Issue description
We'll flesh out details a bit more with PM, but enterprise should be able to configure a policy that either pre-mounts or pre-populates the share list.
Minimal implementation
-------------------
At the least it probably consists of a list of { share_path:string, should_mount_automatically:bool }
When should_mount_automatically is false then the entry is just pre-populated in the discovery list. When true, we should try to mount the share at login (similar to how remount works)
Mounting will only work for kerberos (may need some refactor) and no-password share in minimal implementation.
Additional features
- Support $USER variable. This is a common scenario to mount a users network share. eg. \\server\share\users\$USER
- Support $PASSWORD to use the users login password
- If we get other files app features like letting the share be in a "dormant" state then we can delay mount until first use, and possibly haave active UI action to prompt use to enter password for protected shares.
,
Oct 2
,
Oct 7
,
Oct 10
M71: Allow preconfiguring shares to appear in the discovery dropdown via policy M72: Look at more complex scenarios such as premounting and passing through credentials
,
Oct 11
,
Oct 11
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/916bede878d540535d4e0651be1cc8a6d530ac21 commit 916bede878d540535d4e0651be1cc8a6d530ac21 Author: Bailey Berro <baileyberro@chromium.org> Date: Thu Oct 11 20:55:06 2018 Add policy for preconfigured SMB shares - Adds NetworkFileSharesPreconfiguredShares policy, which allows shares to be preconfigured by a user. Initially the only supported fields are share_url and mode. The only supported mode is drop_down, which adds share_url to the discovery drop down. - In the future, additional modes will be implemented such as a mode that automatically mounts the shares. This will also require adding credential fields to the object. Bug: chromium:878502 Change-Id: I7494e5f9680f313680add379ac3833610d1213a9 Reviewed-on: https://chromium-review.googlesource.com/c/1265903 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#598926} [modify] https://crrev.com/916bede878d540535d4e0651be1cc8a6d530ac21/chrome/browser/chromeos/smb_client/smb_service.cc [modify] https://crrev.com/916bede878d540535d4e0651be1cc8a6d530ac21/chrome/browser/policy/configuration_policy_handler_list_factory.cc [modify] https://crrev.com/916bede878d540535d4e0651be1cc8a6d530ac21/chrome/common/pref_names.cc [modify] https://crrev.com/916bede878d540535d4e0651be1cc8a6d530ac21/chrome/common/pref_names.h [modify] https://crrev.com/916bede878d540535d4e0651be1cc8a6d530ac21/chrome/test/data/policy/policy_test_cases.json [modify] https://crrev.com/916bede878d540535d4e0651be1cc8a6d530ac21/components/policy/resources/policy_templates.json [modify] https://crrev.com/916bede878d540535d4e0651be1cc8a6d530ac21/tools/metrics/histograms/enums.xml
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e60b20c598a465fbb3fcb857dd85dcd212a01974 commit e60b20c598a465fbb3fcb857dd85dcd212a01974 Author: Bailey Berro <baileyberro@chromium.org> Date: Thu Oct 11 21:29:15 2018 Use preconfigured shares in share discovery drop down - Shares preconfigured by policy with drop_down mode are returned during share discovery. Bug: chromium:878502 Change-Id: Ibb2a95c6161d70460fdec77e7dcac1e8cf38650e Reviewed-on: https://chromium-review.googlesource.com/c/1265904 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#598951} [modify] https://crrev.com/e60b20c598a465fbb3fcb857dd85dcd212a01974/chrome/browser/chromeos/smb_client/smb_service.cc [modify] https://crrev.com/e60b20c598a465fbb3fcb857dd85dcd212a01974/chrome/browser/chromeos/smb_client/smb_service.h
,
Oct 12
M71 parts landed in time for branch. Removing M71 label so work for 72 can be tracked
,
Oct 17
,
Nov 20
Goal for M73 is to enable premounting once the first stage in crbug.com/891462 is implemented
,
Dec 19
,
Dec 28
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/8a6109b276b6552bd7a270cd5181343c210bb147 commit 8a6109b276b6552bd7a270cd5181343c210bb147 Author: Jimmy Gong <jimmyxgong@google.com> Date: Thu Jan 17 13:16:15 2019 smbprovider: Add PremounOptionsProto - PremountOptionsProto is used to mount preconfigured shares. Preconfigured shares will be mounted regardless if the share requires credentials or not. - Adds Dbus bindings to support PremountOptionsProto. BUG=chromium:878502 TEST=emerges, unittests Change-Id: I756ff143dc880a8fa7dea2476feea742387e73be Reviewed-on: https://chromium-review.googlesource.com/1407465 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/8a6109b276b6552bd7a270cd5181343c210bb147/smbprovider/smbprovider_test_helper.h [modify] https://crrev.com/8a6109b276b6552bd7a270cd5181343c210bb147/system_api/dbus/smbprovider/directory_entry.proto [modify] https://crrev.com/8a6109b276b6552bd7a270cd5181343c210bb147/smbprovider/proto.h [modify] https://crrev.com/8a6109b276b6552bd7a270cd5181343c210bb147/system_api/dbus/smbprovider/dbus-constants.h [modify] https://crrev.com/8a6109b276b6552bd7a270cd5181343c210bb147/smbprovider/smbprovider_test_helper.cc [modify] https://crrev.com/8a6109b276b6552bd7a270cd5181343c210bb147/smbprovider/proto_test.cc [modify] https://crrev.com/8a6109b276b6552bd7a270cd5181343c210bb147/smbprovider/proto.cc
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/04521998a4eff3e19d813ba4fd9df8d05ea09a2f commit 04521998a4eff3e19d813ba4fd9df8d05ea09a2f Author: Jimmy Gong <jimmyxgong@google.com> Date: Thu Jan 17 13:16:15 2019 smbprovider: Add Premount to MountManager - Adds Premount function to MountManager. - Adds unit test to reflect this change. BUG=chromium:878502 TEST=unit tests Change-Id: Ia4f369b1dd3045ed4ffc7bfea9fb4695ddfbe533 Reviewed-on: https://chromium-review.googlesource.com/1407466 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Bailey Berro <baileyberro@chromium.org> [modify] https://crrev.com/04521998a4eff3e19d813ba4fd9df8d05ea09a2f/smbprovider/mount_manager.cc [modify] https://crrev.com/04521998a4eff3e19d813ba4fd9df8d05ea09a2f/smbprovider/mount_manager.h [modify] https://crrev.com/04521998a4eff3e19d813ba4fd9df8d05ea09a2f/smbprovider/mount_manager_test.cc
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/87597881ee1b9b103eec71b56033415364660dd1 commit 87597881ee1b9b103eec71b56033415364660dd1 Author: Jimmy Gong <jimmyxgong@google.com> Date: Sat Jan 19 04:05:11 2019 smbprovider: Add CanReachHost to SmbProvider - CanReachHost is used to determine if a share is reachable, regardless of if it can be authenticated to. - Renamed CanAccessMount to CanReadMountRoot for more clarity. BUG=chromium:878502 TEST=unit test Change-Id: I5588d86b703607d4f4cc92ddc4bc4959b1194ab2 Reviewed-on: https://chromium-review.googlesource.com/1407467 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/87597881ee1b9b103eec71b56033415364660dd1/smbprovider/smbprovider.cc [modify] https://crrev.com/87597881ee1b9b103eec71b56033415364660dd1/smbprovider/smbprovider.h
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/f0e4ea294b477bc69a2f056e6734055fbc78d586 commit f0e4ea294b477bc69a2f056e6734055fbc78d586 Author: Jimmy Gong <jimmyxgong@google.com> Date: Sat Jan 19 04:05:11 2019 smbprovider: Add Premount to SmbProvider - Adds D-Bus hooks for Premount so that SmbProvider can call on Premount from chromium. - Adds Premount method to SmbProvider. - Add unit tests to reflect on this change. BUG=chromium:878502 TEST=unit test, end to end Change-Id: I3507e14aa5b166c90ec2c29bf941f8855eae190e Reviewed-on: https://chromium-review.googlesource.com/1407808 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/f0e4ea294b477bc69a2f056e6734055fbc78d586/smbprovider/etc/dbus-1/org.chromium.SmbProvider.conf [modify] https://crrev.com/f0e4ea294b477bc69a2f056e6734055fbc78d586/smbprovider/dbus_bindings/org.chromium.SmbProvider.xml [modify] https://crrev.com/f0e4ea294b477bc69a2f056e6734055fbc78d586/smbprovider/smbprovider_test.cc [modify] https://crrev.com/f0e4ea294b477bc69a2f056e6734055fbc78d586/smbprovider/smbprovider.h [modify] https://crrev.com/f0e4ea294b477bc69a2f056e6734055fbc78d586/smbprovider/smbprovider.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by osh...@chromium.org
, Sep 28