Refactor to remove GetCredentialForTesting method |
|||
Issue descriptionWe don't need to expose this for testing purposes. Refactor MountManager so that AddMount/Remount take an SmbCredential instead of the 3 component parts. Update the tests so that they create the credential and pass it to AddMount/Remount. Remove the calls to GetCredentialForTesting, and use the credential we just created as the "expected" value instead.
,
Sep 4
,
Sep 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/58c3bd3554ce2136d9032444fd5aab0ec0a70ad6 commit 58c3bd3554ce2136d9032444fd5aab0ec0a70ad6 Author: Jimmy Gong <jimmyxgong@google.com> Date: Sat Sep 08 05:27:27 2018 smbprovider: Refactor Add/Remount Mount in MountManager - Refactored Add/Remount Mount in MountManager to take an SmbCredential as a parameter. - Removed GetCredentialFromMountIdForTesting(). - Updated unit tests in MountManagerTest to reflect on this change. BUG= chromium:878499 TEST=unit test Change-Id: I994bc2a210857fa242997fd6b8e47041c7e5e531 Reviewed-on: https://chromium-review.googlesource.com/1199948 Commit-Ready: jimmy gong <jimmyxgong@chromium.org> Tested-by: jimmy gong <jimmyxgong@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/58c3bd3554ce2136d9032444fd5aab0ec0a70ad6/smbprovider/mount_manager.cc [modify] https://crrev.com/58c3bd3554ce2136d9032444fd5aab0ec0a70ad6/smbprovider/mount_manager.h [modify] https://crrev.com/58c3bd3554ce2136d9032444fd5aab0ec0a70ad6/smbprovider/mount_manager_test.cc [modify] https://crrev.com/58c3bd3554ce2136d9032444fd5aab0ec0a70ad6/smbprovider/smbprovider.h [modify] https://crrev.com/58c3bd3554ce2136d9032444fd5aab0ec0a70ad6/smbprovider/smbprovider.cc
,
Sep 18
|
|||
►
Sign in to add a comment |
|||
Comment 1 by baileyberro@chromium.org
, Aug 31