... and silently. It is honestly impossible to not rant about the pathetic code quality of the autotest codebase.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f843a83c89c12361877f3a6c4cb4b785c05a504d commit f843a83c89c12361877f3a6c4cb4b785c05a504d Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:58:00 2018 autotest: Delete a terrible hack This hack means nothing post the migration to HostInfoStore. If there are any labels to be had, they're in the store. If there aren't any labels in the store, they don't exist. BUG= chromium:878497 TEST=None Change-Id: Ib645cf817672cb1ad4de2e0b030b53a9a2c8ae23 Reviewed-on: https://chromium-review.googlesource.com/1195066 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/f843a83c89c12361877f3a6c4cb4b785c05a504d/server/cros/network/wifi_cell_test_base.py [modify] https://crrev.com/f843a83c89c12361877f3a6c4cb4b785c05a504d/client/common_lib/utils.py [modify] https://crrev.com/f843a83c89c12361877f3a6c4cb4b785c05a504d/server/site_tests/network_WiFi_RateControl/network_WiFi_RateControl.py [modify] https://crrev.com/f843a83c89c12361877f3a6c4cb4b785c05a504d/server/cros/network/wifi_client.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cbd5ebb8e9ea487ccc81611c82b96ab12da46cd2 commit cbd5ebb8e9ea487ccc81611c82b96ab12da46cd2 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:58:00 2018 autotest: Extract is_in_{moblab,ssp_moblab,lab} functions BUG= chromium:878497 TEST=manual Change-Id: I85a9fb2d664dfaf86168139a4e0b6e077f608ae2 Reviewed-on: https://chromium-review.googlesource.com/1195067 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/cbd5ebb8e9ea487ccc81611c82b96ab12da46cd2/server/hosts/servo_host.py [modify] https://crrev.com/cbd5ebb8e9ea487ccc81611c82b96ab12da46cd2/client/common_lib/utils.py [modify] https://crrev.com/cbd5ebb8e9ea487ccc81611c82b96ab12da46cd2/server/site_utils.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f605dd3e836fc8ac7c87bea8e77daca35a631620 commit f605dd3e836fc8ac7c87bea8e77daca35a631620 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:58:01 2018 autotest: Inline ServoHost(is_in_lab) argument computation BUG= chromium:878497 TEST=manual Change-Id: I309a2e56d3ae5183fce7c41acb5740367f3f4ae9 Reviewed-on: https://chromium-review.googlesource.com/1195068 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/f605dd3e836fc8ac7c87bea8e77daca35a631620/server/hosts/servo_host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/efb1b48e18c6c5e77d9fbce35172bc5c50b7778f commit efb1b48e18c6c5e77d9fbce35172bc5c50b7778f Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:58:02 2018 autotest: Extract _tweak_args_for_ssp_moblab() BUG= chromium:878497 TEST=None Change-Id: Ibc10d8736b0b7cdb8f52db25c66a79e897e6a798 Reviewed-on: https://chromium-review.googlesource.com/1195069 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Allen Li <ayatane@chromium.org> [modify] https://crrev.com/efb1b48e18c6c5e77d9fbce35172bc5c50b7778f/server/hosts/servo_host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cba44291bbb3b2a7e02ab24017c8e227a688172c commit cba44291bbb3b2a7e02ab24017c8e227a688172c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:58:03 2018 autotest: Use HostInfo to extract servo arguments from CrosHost BUG= chromium:878497 TEST=manual Change-Id: I720281edb71aee51822e929203b4bd0a82a169bb Reviewed-on: https://chromium-review.googlesource.com/1195070 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/cba44291bbb3b2a7e02ab24017c8e227a688172c/server/hosts/servo_host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/723ca4ff21e09391ac74284789673f00623862a0 commit 723ca4ff21e09391ac74284789673f00623862a0 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:58:03 2018 autotest: Skip host autodetection on connectivity problems BUG= chromium:878497 TEST=manual Change-Id: I19bb195268d24af7962be1b4477d836884a410df Reviewed-on: https://chromium-review.googlesource.com/1194436 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/723ca4ff21e09391ac74284789673f00623862a0/server/hosts/factory_unittest.py [modify] https://crrev.com/723ca4ff21e09391ac74284789673f00623862a0/server/hosts/factory.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/0117a5926808c4f02638a917a908a71fc7cfc89c commit 0117a5926808c4f02638a917a908a71fc7cfc89c Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:57:58 2018 autotest: Clip connection timeout when larger than overall timeout D'oh! BUG= chromium:878497 TEST=None Change-Id: Icd7258e05b48ea28d28ba8a00fbe88b88bceebc9 Reviewed-on: https://chromium-review.googlesource.com/1194439 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/0117a5926808c4f02638a917a908a71fc7cfc89c/server/hosts/ssh_host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f0507425d51c9fa2574a43dd440c56f6d3c4b024 commit f0507425d51c9fa2574a43dd440c56f6d3c4b024 Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:57:58 2018 autotest: Respect overall timeout in SSHHost.run_very_slowly() ... even though it says _very_slowly(), make it more deterministically slow. BUG= chromium:878497 TEST=manual Change-Id: Ib1199690b58f5ca2978eb7dcafa752090d0ab054 Reviewed-on: https://chromium-review.googlesource.com/1194440 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/f0507425d51c9fa2574a43dd440c56f6d3c4b024/server/hosts/abstract_ssh.py [modify] https://crrev.com/f0507425d51c9fa2574a43dd440c56f6d3c4b024/server/hosts/ssh_host.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/88bf6054500d082f349522d64cdd72e648d293ae commit 88bf6054500d082f349522d64cdd72e648d293ae Author: Prathmesh Prabhu <pprabhu@chromium.org> Date: Mon Sep 03 20:57:59 2018 autotest: Make servo creation decision tree verbose There is currently no way to know from logs why exactly servo creation went the way it did. BUG= chromium:878497 TEST=manual Change-Id: Id3f0b5e3e8363445e179c7b2d7bc07c608a7af8e Reviewed-on: https://chromium-review.googlesource.com/1195065 Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/88bf6054500d082f349522d64cdd72e648d293ae/server/hosts/cros_host.py [modify] https://crrev.com/88bf6054500d082f349522d64cdd72e648d293ae/server/hosts/servo_host.py
This bug should be fixed pending prod push.
w00t! https://chrome-swarming.appspot.com/task?id=3fc49567187be810&refresh=10 https://chrome-swarming.appspot.com/task?id=3fc4917483d03710&refresh=10 OTOH, what's up with bugdroid?
