New issue
Advanced search Search tips

Issue 878496 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Cleanup: Fix method names, members where Credential is plural.

Project Member Reported by zentaro@chromium.org, Aug 28

Issue description

As a follow up to this CL https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1179229/10

which renamed the type SmbCredential. Also update the various methods and members that are still using the plural name.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/eb77fe8d978d108bd5a24fbe4c0d7d727b94123a

commit eb77fe8d978d108bd5a24fbe4c0d7d727b94123a
Author: Jimmy Gong <jimmyxgong@google.com>
Date: Sat Sep 08 05:27:27 2018

smbprovider: Cleanup plurals from 'credentials'

- Simple cleanup to remove unnecessary plural from "credentials".

BUG= chromium:878496 
TEST=emerges

Change-Id: I55ab0dc84f9668484d4ea54cb6702a7d2049f7a6
Reviewed-on: https://chromium-review.googlesource.com/1205730
Commit-Ready: jimmy gong <jimmyxgong@chromium.org>
Tested-by: jimmy gong <jimmyxgong@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>

[modify] https://crrev.com/eb77fe8d978d108bd5a24fbe4c0d7d727b94123a/smbprovider/mount_manager.cc

Status: Fixed (was: Started)

Sign in to add a comment