Ensure good error message when mount fails due to SMB1 |
|||||||
Issue descriptionWhen connecting to a NAS device that only supports SMB1 we need to give a descriptive error message to specifically identify this case. To reproduce, use one of the devices we have that is configured to only support SMB1. Ask Bailey to help you if you aren't sure. I think WDSHARE currently doesn't support SMB. You can also setup the Apple time machine that is there. I think it also doesn't support SMB1. Try to connect to such a device and we need to get an error message that says something along the lines of "This device is not supported. Ensure the device supports SMB2 or higher." I think there's already a UI string (but maybe it's not being mapped corectly) that says the device is not supported, but it also needs to be updated to mention SMB1 specifically. Can ask Bailey where this string is. There is a low level error from mount (UNSUPPORTED_DEVICE) but I don't think it gets mapped correctly all the way up to the UI layer. https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/downloads_page/smb_browser_proxy.js?sq=package:chromium&q=UNSUPPORTED_DEVICE&g=0&l=20 You need to ensure the error is mapped correctly up all the various layers to the UI. This may include adding new items to error enums, and to functions that map errors at various layers. Then also update the UI text with the additional SMB1 test.
,
Aug 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6043735469b17bba11ddb9001844230f480728bb commit 6043735469b17bba11ddb9001844230f480728bb Author: Bailey Berro <baileyberro@chromium.org> Date: Fri Aug 31 12:23:17 2018 smbprovider: Use more descriptive error message for SMB1 This change maps a new errno to ERROR_SMB1_UNSUPPORTED in order to display a more descriptive error message when a share fails to mount because we do not support SMB1. BUG= chromium:878493 TEST=unittests Change-Id: I4f5c79ce5b1bf5931d2f59632f256f2b0712fda2 Reviewed-on: https://chromium-review.googlesource.com/1196947 Commit-Ready: Bailey Berro <baileyberro@chromium.org> Tested-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/6043735469b17bba11ddb9001844230f480728bb/smbprovider/smbprovider_helper.cc [modify] https://crrev.com/6043735469b17bba11ddb9001844230f480728bb/smbprovider/smbprovider_helper_test.cc
,
Aug 31
,
Sep 26
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 26
The change in comment #6 should be merged in addition
,
Sep 28
Please add OS.
,
Sep 28
,
Sep 28
,
Oct 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/46d55ec535cab255399ff8bdcedee3431b6d1870 commit 46d55ec535cab255399ff8bdcedee3431b6d1870 Author: Bailey Berro <baileyberro@chromium.org> Date: Tue Oct 02 13:12:39 2018 smbprovider: Use more descriptive error message for SMB1 This change maps a new errno to ERROR_SMB1_UNSUPPORTED in order to display a more descriptive error message when a share fails to mount because we do not support SMB1. BUG= chromium:878493 TEST=unittests Change-Id: I4f5c79ce5b1bf5931d2f59632f256f2b0712fda2 Reviewed-on: https://chromium-review.googlesource.com/1196947 Commit-Ready: Bailey Berro <baileyberro@chromium.org> Tested-by: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> (cherry picked from commit 6043735469b17bba11ddb9001844230f480728bb) Reviewed-on: https://chromium-review.googlesource.com/1256118 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Tested-by: Zentaro Kavanagh <zentaro@chromium.org> [modify] https://crrev.com/46d55ec535cab255399ff8bdcedee3431b6d1870/smbprovider/smbprovider_helper.cc [modify] https://crrev.com/46d55ec535cab255399ff8bdcedee3431b6d1870/smbprovider/smbprovider_helper_test.cc
,
Oct 2
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 5
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by baileyberro@chromium.org
, Aug 29Status: Started (was: Assigned)