New issue
Advanced search Search tips

Issue 878489 link

Starred by 0 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Launcher-Polish


Sign in to add a comment

Request app icon for shelf at the exact size

Project Member Reported by kaznacheev@chromium.org, Aug 28

Issue description

Currently ChromeLauncherController is creating AppIconLoader instances with the requested icon size equal to extension_misc::EXTENSION_ICON_MEDIUM. This size is greater than the actual size of shelf icons, so some downsampling is applied.

It would be better if the icons were requested at the exact size and rescaling was only done once in the icon loader code.
 
Components: UI>Shell>Shelf
Cc: -manucornet@chromium.org kaznacheev@chromium.org
Labels: -Pri-2 -M-71 Pri-3
Owner: manucornet@chromium.org
I believe that this is not really necessary. No one has complained about artifacts yet.

OTOH a complete and clean implementation of this idea would require changing the size of bundled icons for default apps, or rather adding another size (44dp) to existing 32, 48 and 64. This is cumbersome and not really scalable.

What probably still makes sense is decoupling the icon size from extension_misc::EXTENSION_ICON_MEDIUM and using some dedicated value specified in shelf_constants.h


Sign in to add a comment