New issue
Advanced search Search tips

Issue 878462 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 29
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Infra/infra is broken on Win-32

Project Member Reported by tandrii@chromium.org, Aug 28

Issue description

win-32 isn't in CQ and gatekeeper is broken, so I didn't notice this for long time. Anyhow, https://chromium-review.googlesource.com/c/infra/infra/+/1179429 is the CL after which builder turned red. Here is its first build https://ci.chromium.org/p/infra/builders/luci.infra.ci/infra-continuous-win7-32/4699


PACKAGE: infra/appengine/rotang/pkg/algo
--------------------------------------------------------------------------------
--- FAIL: TestGenerate (0.00s)
	fair_test.go:336: Random when not providing any previous shifts: Generate(_) differs -want +got:  [
		  {
		   Name: "Test Shift",
		   OnCall: [
		    {
		-    Email: "I@I.com",
		+    Email: "B@B.com",
		     ShiftName: "Test Shift",
		    },
		   ],
		   StartTime: 2006-01-02 00:00:00 +0000 UTC,
		   EndTime: 2006-01-07 00:00:00 +0000 UTC,
		   Comment: "",
		  },
		  {
		   Name: "Test Shift",
		   OnCall: [
		    {
		-    Email: "C@C.com",
		+    Email: "G@G.com",
		     ShiftName: "Test Shift",
		    },
		   ],
		   StartTime: 2006-01-09 00:00:00 +0000 UTC,
		   EndTime: 2006-01-14 00:00:00 +0000 UTC,
		   Comment: "",
		  },
		  {
		   Name: "Test Shift",
		   OnCall: [
		    {
		-    Email: "F@F.com",
		+    Email: "A@A.com",
		     ShiftName: "Test Shift",
		    },
		   ],
		   StartTime: 2006-01-16 00:00:00 +0000 UTC,
		   EndTime: 2006-01-21 00:00:00 +0000 UTC,
		   Comment: "",
		  },
		  {
		   Name: "Test Shift",
		   OnCall: [
		    {
		-    Email: "A@A.com",
		+    Email: "D@D.com",
		     ShiftName: "Test Shift",
		    },
		   ],
		   StartTime: 2006-01-23 00:00:00 +0000 UTC,
		   EndTime: 2006-01-28 00:00:00 +0000 UTC,
		   Comment: "",
		  },
		 ]
FAIL
coverage: 88.7% of statements
FAIL	infra/appengine/rotang/pkg/algo	0.028s
 
EstimatedDays: 1
Looks like the Win32 Pseudo Random Generator generates a different sequence on Win32 , or maybe on all 32 bit platforms. 

I'll figure this out today.
Question is how I can rerun this build/test to test things out.
That's a great question. I don't actually have an easy answer today -- git cl try won't work because we don't have win32 try bot.

You could, however, go to recent task, then click "DEBUG"
https://chromium-swarm.appspot.com/task?id=3f9be3819f004310&refresh=10
and then you get access to actual bot.

That said, frankly I don't see a good reason to just add conditional compilation to your test (rename test file per https://golang.org/pkg/go/build/) to skip tests on 32-bit platforms entirely.

Yes I am writing a cl with conditional compilation, just curious about what's happening. 

Thx. for clearing that one out, CL coming up.
Correction: 

> That said, frankly I don't see a good reason to just add conditional compilation

I meant I do NOT see any reason to NOT add conditional compilation. ie, go ahead!
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 29

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/4f37032eec811133388abe9373bf8a3ec98a97a9

commit 4f37032eec811133388abe9373bf8a3ec98a97a9
Author: Ola Karlsson <olakar@chromium.org>
Date: Wed Aug 29 02:37:15 2018

One of the Random order tests fail on Win32

- Moved the Fair Generator Random test over to the random file.
- Added +build !386 to the random_test.go file.


Bug:  878462 
Change-Id: Ic90158088a416b031be91e126d5a9a832d898bc4
Reviewed-on: https://chromium-review.googlesource.com/1194523
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ola Karlsson <olakar@chromium.org>

[modify] https://crrev.com/4f37032eec811133388abe9373bf8a3ec98a97a9/go/src/infra/appengine/rotang/pkg/algo/fair_test.go
[modify] https://crrev.com/4f37032eec811133388abe9373bf8a3ec98a97a9/go/src/infra/appengine/rotang/pkg/algo/random_test.go
[modify] https://crrev.com/4f37032eec811133388abe9373bf8a3ec98a97a9/go/src/infra/appengine/rotang/pkg/algo/algo.infra_testing

Status: Fixed (was: Assigned)

Sign in to add a comment