New issue
Advanced search Search tips

Issue 878460 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

AudioContext should work with MEI

Project Member Reported by beccahughes@chromium.org, Aug 28

Issue description

AudioContext playbacks should be counted in MEI
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb380be631093613e22041e2c899745acf7f87aa

commit fb380be631093613e22041e2c899745acf7f87aa
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Aug 31 01:01:36 2018

[Media Engagement] Add storage for AudioContext

Add a media element playbacks and an audio
context playbacks field to the
MediaEngagmentScore. The media element playbacks
field should be pre-populated with the current
media playbacks value (as all previous playbacks
would be from media elements).

BUG= 878460 

Change-Id: If34b468bddf1cefaf753e0acd220afa1f100331b
Reviewed-on: https://chromium-review.googlesource.com/1194690
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587888}
[modify] https://crrev.com/fb380be631093613e22041e2c899745acf7f87aa/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/fb380be631093613e22041e2c899745acf7f87aa/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/fb380be631093613e22041e2c899745acf7f87aa/chrome/browser/media/media_engagement_score_unittest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8

commit e4555db0b7e7f8dad896864b4e85ed9bd15b36a8
Author: Becca Hughes <beccahughes@chromium.org>
Date: Fri Aug 31 01:23:06 2018

[Media Engagement] Track AudioContext playbacks

Adds AudioContext player tracking to MediaEngagementContentsObserver
with it's own page level timer. On MediaEngagementSession this CL
seperates significant playback into media element playback and
audio context playback. Since we may record a playback we need to
disable committing on significant playback and just record on
destroy or navigate instead.

BUG= 878460 

Change-Id: Ic66152f8cb5b3a6338804c04de7dd0bf5c1cb154
Reviewed-on: https://chromium-review.googlesource.com/1194992
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587899}
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_browsertest.cc
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_service.cc
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_service.h
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_service_unittest.cc
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_session.cc
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_session.h
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/browser/media/media_engagement_session_unittest.cc
[modify] https://crrev.com/e4555db0b7e7f8dad896864b4e85ed9bd15b36a8/chrome/test/data/webui/media/media_engagement_browsertest.js

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b92cb9cac4722908a39427ea31746da2656df9cd

commit b92cb9cac4722908a39427ea31746da2656df9cd
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Sep 05 23:05:45 2018

[Autoplay] Add audio context feature

Add a feature to disable AudioContext playbacks counting
towards the MEI score.

BUG= 878460 

Change-Id: I486f3853ebc26a703e52712bee13600c99c7be14
Reviewed-on: https://chromium-review.googlesource.com/1204728
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589046}
[modify] https://crrev.com/b92cb9cac4722908a39427ea31746da2656df9cd/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/b92cb9cac4722908a39427ea31746da2656df9cd/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/b92cb9cac4722908a39427ea31746da2656df9cd/media/base/media_switches.cc
[modify] https://crrev.com/b92cb9cac4722908a39427ea31746da2656df9cd/media/base/media_switches.h

Labels: Merge-Request-70
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 6

Labels: -Merge-Request-70 Hotlist-Merge-Approved Merge-Approved-70
Your change meets the bar and is auto-approved for M70. Please go ahead and merge the CL to branch 3538 manually. Please contact milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 6

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a44bdb1d63873f0d0c7567549693b8c628abcfb5

commit a44bdb1d63873f0d0c7567549693b8c628abcfb5
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Sep 06 23:17:59 2018

[Media Engagement] Add storage for AudioContext

Add a media element playbacks and an audio
context playbacks field to the
MediaEngagmentScore. The media element playbacks
field should be pre-populated with the current
media playbacks value (as all previous playbacks
would be from media elements).

BUG= 878460 

Change-Id: If34b468bddf1cefaf753e0acd220afa1f100331b
Reviewed-on: https://chromium-review.googlesource.com/1194690
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587888}(cherry picked from commit fb380be631093613e22041e2c899745acf7f87aa)
Reviewed-on: https://chromium-review.googlesource.com/1211673
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#109}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/a44bdb1d63873f0d0c7567549693b8c628abcfb5/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/a44bdb1d63873f0d0c7567549693b8c628abcfb5/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/a44bdb1d63873f0d0c7567549693b8c628abcfb5/chrome/browser/media/media_engagement_score_unittest.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc

commit 693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Sep 06 23:18:26 2018

[Media Engagement] Track AudioContext playbacks

Adds AudioContext player tracking to MediaEngagementContentsObserver
with it's own page level timer. On MediaEngagementSession this CL
seperates significant playback into media element playback and
audio context playback. Since we may record a playback we need to
disable committing on significant playback and just record on
destroy or navigate instead.

BUG= 878460 

Change-Id: Ic66152f8cb5b3a6338804c04de7dd0bf5c1cb154
Reviewed-on: https://chromium-review.googlesource.com/1194992
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587899}(cherry picked from commit e4555db0b7e7f8dad896864b4e85ed9bd15b36a8)
Reviewed-on: https://chromium-review.googlesource.com/1211874
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#110}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_browsertest.cc
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_score.h
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_service.cc
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_service.h
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_service_unittest.cc
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_session.cc
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_session.h
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/browser/media/media_engagement_session_unittest.cc
[modify] https://crrev.com/693d01dc4e4eb0fe3517c89b9b2fe804b935f4cc/chrome/test/data/webui/media/media_engagement_browsertest.js

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06ccf9065a9bc51ef627b6c13dfbb1c32d92cdf8

commit 06ccf9065a9bc51ef627b6c13dfbb1c32d92cdf8
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Sep 06 23:18:33 2018

[Media Engagement] Add new fields to WebUI

Add the audio context and media element playbacks fields
to the Media Engagement WebUI.

BUG= 878460 

Change-Id: I25a2bdc28a9b98355269e56072c6dc98a019456a
Reviewed-on: https://chromium-review.googlesource.com/1195101
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#587909}(cherry picked from commit f4ffbd80ef5a5df24346d954ed1c1f10c62fde43)
Reviewed-on: https://chromium-review.googlesource.com/1211674
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#111}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/06ccf9065a9bc51ef627b6c13dfbb1c32d92cdf8/chrome/browser/media/media_engagement_score.cc
[modify] https://crrev.com/06ccf9065a9bc51ef627b6c13dfbb1c32d92cdf8/chrome/browser/media/media_engagement_score_details.mojom
[modify] https://crrev.com/06ccf9065a9bc51ef627b6c13dfbb1c32d92cdf8/chrome/browser/media/media_engagement_score_unittest.cc
[modify] https://crrev.com/06ccf9065a9bc51ef627b6c13dfbb1c32d92cdf8/chrome/browser/resources/media/media_engagement.html
[modify] https://crrev.com/06ccf9065a9bc51ef627b6c13dfbb1c32d92cdf8/chrome/browser/resources/media/media_engagement.js

Status: Fixed (was: Started)
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51b1f57f4459d61bc208abbeb421d2e64fec60f3

commit 51b1f57f4459d61bc208abbeb421d2e64fec60f3
Author: Becca Hughes <beccahughes@chromium.org>
Date: Thu Sep 06 23:18:55 2018

[Autoplay] Add audio context feature

Add a feature to disable AudioContext playbacks counting
towards the MEI score.

BUG= 878460 

Change-Id: I486f3853ebc26a703e52712bee13600c99c7be14
Reviewed-on: https://chromium-review.googlesource.com/1204728
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589046}(cherry picked from commit b92cb9cac4722908a39427ea31746da2656df9cd)
Reviewed-on: https://chromium-review.googlesource.com/1211675
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#112}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/51b1f57f4459d61bc208abbeb421d2e64fec60f3/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/51b1f57f4459d61bc208abbeb421d2e64fec60f3/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/51b1f57f4459d61bc208abbeb421d2e64fec60f3/media/base/media_switches.cc
[modify] https://crrev.com/51b1f57f4459d61bc208abbeb421d2e64fec60f3/media/base/media_switches.h

Sign in to add a comment