New issue
Advanced search Search tips

Issue 878453 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 30
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Use "AbortError: Another PaymentRequest UI is already open"

Project Member Reported by rouslan@chromium.org, Aug 28

Issue description

Use "AbortError: Another PaymentRequest UI is already open."
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2d233c40cf68e6d66ed9788d211a63086711be6

commit b2d233c40cf68e6d66ed9788d211a63086711be6
Author: Rouslan Solomakhin <rouslan@chromium.org>
Date: Thu Aug 30 16:18:40 2018

AbortError: Another PaymentRequest UI is already showing.

Before this patch, if a user attempted to open a second PaymentRequest
UI in a separate tab or window, the .show() promise would be rejected
with "AbortError: Request cancelled." This generic error message created
confusion about the reason why the PaymentRequest UI could not be
opened.

This patch keeps the AbortError, but makes the web developer visible
error message more specific to this error condition.

After this patch, if a user attempts to open a second PaymentRequest UI
in a separate tab or window, the .show() promise is rejected with
"AbortError: Another PaymentRequest UI is already showing in a
different tab or window."

Bug:  878453 
Change-Id: I5d27171e21b69cfd5fc95a0a72cb6efce343ea5d
Reviewed-on: https://chromium-review.googlesource.com/1195650
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#587610}
[modify] https://crrev.com/b2d233c40cf68e6d66ed9788d211a63086711be6/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/b2d233c40cf68e6d66ed9788d211a63086711be6/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/b2d233c40cf68e6d66ed9788d211a63086711be6/components/payments/content/payment_request.cc
[modify] https://crrev.com/b2d233c40cf68e6d66ed9788d211a63086711be6/third_party/blink/public/mojom/payments/payment_request.mojom
[modify] https://crrev.com/b2d233c40cf68e6d66ed9788d211a63086711be6/third_party/blink/renderer/modules/payments/payment_request.cc

Status: Fixed (was: Assigned)

Sign in to add a comment