New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 878443 link

Starred by 2 users
Status: Assigned
Owner:
markchang@chromium.org
Cc:
ew...@chromium.org
sabineb@chromium.org
tangltom@chromium.org
markchang@chromium.org
█ manasverma@google.com
█ jtonollo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

contextual promo button text color is wrong

Project Member Reported by rfeng@chromium.org, Aug 28 
Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1)log out of Chrome 
(2)save a bookmark 
(3)the "sign in" text color is darker than others 

What is the expected result?

the "sign in" text color should be consistent with others  
We need to fix this for all contextual promos. (Passwords, cards, extensions, bookmarks)


What happens instead?



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
error.png
382 KB View Download

Comment 1 by ew...@chromium.org, Aug 28

Cc: -johannes@chromium.org jtonollo@chromium.org tangltom@chromium.org ew...@chromium.org sabineb@chromium.org
Labels: -Pri-1 -OS-Chrome Pri-2
Owner: markchang@chromium.org
This is only relevant for the bookmark bubble promo, where we show the grey "sign in" button. In all other promos, the "sign in" button is blue. We use the grey one here because there's another blue primary action button.

I'm not sure when this button text color got changed, but I don't think it was due to a change the sign in team made. Mark - do you know if it was due to a desktop UI change related to GM2?

Comment 2 by jmukthavaram@chromium.org, Nov 26

Labels: Hotlist-DesktopUIChecked
** UI Mass Triage**

As per above steps in C#0, Seems UI got changed in M72 on all OS .Now we can see 'Turn on sync' button instead of 'Signin' & Seems its consistent all other as expected. Adding respective labels.

Comment 3 by benhenry@google.com, Jan 11

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
►

Sign in to add a comment